[AutoGeneration] SecurityInsights module (1.2.0)

[dicolanl]

Description

Per feedback on PR #17286 moving to a dedicated branch

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[ghost]

Thank you for your contribution dicolanl! We will review the pull request and get back to you soon.

[ghost]

All CLA requirements met.

[BethanyZhou]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[BethanyZhou]

Generally looks good to me except few comments.

[BethanyZhou]

Generally looks good to me

[BethanyZhou]

Hi @dicolanl ,

seems like the syntaxes of cmdlets are different with previous design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1161, just reviewed current design again.

For New/Update-AzSentinelDataConnector,

• Change Indicators, Teams, Incidents, DiscoveryLogs to their singular form

For Update-AzSentinelAlertRule,

• parameter set 'UpdateViaIdentityFusionMLTI', 'UpdateViaIdentityMicrosoftSecurityIncidentCreation', 'UpdateViaIdentityNRT', 'UpdateViaIdentityUpdateScheduled' have the same mandatory parameters, and both of them are not default parameter set which may cause confusion.
• please add a mandatory to differentiate them or combine them as one parameter set

Update-AzSentinelDataConnector, Update-AzSentinelDataConnector, Update-AzSentinelSetting, they have similar issue with Update-AzSentinelAlertRule,

• please add a mandatory to differentiate their parameter sets or combine all parameter sets as one parameter set

please raise a PR target to gen/SecurityInsights and modify current cmdlets.