[AutoGeneration] SecurityInsights module (1.2.0)#17286
[AutoGeneration] SecurityInsights module (1.2.0)#17286dicolanl wants to merge 20 commits intoAzure:generationfrom dicolanl:generation
Conversation
BethanyZhou
left a comment
There was a problem hiding this comment.
Please submit a design review for cmdlets at https://github.com/Azure/azure-powershell-cmdlet-review-pr
|
FYI, Migrating it from handcrafted from generated will cause breaking changes. As Az.SecurityInsights is a GAed module, have you talked with our PM Damien? |
Yes, we did and dicussed moving to autogeneration mode |
When you plan to do this change? |
It's already in place and taking advantage of autogeneration |
to add more context. we talked with Damien awhile ago. we were waiting on the RP to create a new set of APIs, which they have now released. so we wanted to move to this model as the RP plans to release updates monthly to the API and autogeneration will make it easier to keep POSH up to date. |
|
Got it. Please go ahead. |
|
Hi @dicolanl , could you please submit a design review for new generated cmdlets at https://github.com/Azure/azure-powershell-cmdlet-review-pr? |
|
@tianderturpijn will need to do it. I can't see that repo. |
|
Could you please join Azure organization on GitHub. I think you can access after that. |
|
@BethanyZhou the design review was recently accepted: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1161. Is it possible to merge this PR? |
|
@VeryEarly Are there any more steps we need to take for this PR? When can the PR be merged? When will there be a new release? Thank you! |
Description
-Updated SecurityInsights Module using new preview API (https://github.com/Azure/azure-rest-api-specs/tree/main/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview)
-Moved module to use autogeneration
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added