Skip to content

[AutoGeneration] SecurityInsights module (1.2.0)#17286

Closed
dicolanl wants to merge 20 commits intoAzure:generationfrom
dicolanl:generation
Closed

[AutoGeneration] SecurityInsights module (1.2.0)#17286
dicolanl wants to merge 20 commits intoAzure:generationfrom
dicolanl:generation

Conversation

@dicolanl
Copy link
Contributor

@dicolanl dicolanl commented Feb 28, 2022

Description

-Updated SecurityInsights Module using new preview API (https://github.com/Azure/azure-rest-api-specs/tree/main/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2021-10-01-preview)
-Moved module to use autogeneration

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@dicolanl
Copy link
Contributor Author

@tianderturpijn @anat-gilenson FYI

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BethanyZhou
Copy link
Contributor

FYI, Migrating it from handcrafted from generated will cause breaking changes. As Az.SecurityInsights is a GAed module, have you talked with our PM Damien?

@tianderturpijn
Copy link
Contributor

FYI, Migrating it from handcrafted from generated will cause breaking changes. As Az.SecurityInsights is a GAed module, have you talked with our PM Damien?

Yes, we did and dicussed moving to autogeneration mode

@BethanyZhou
Copy link
Contributor

Yes, we did and dicussed moving to autogeneration mode

When you plan to do this change?

@tianderturpijn
Copy link
Contributor

Yes, we did and dicussed moving to autogeneration mode

When you plan to do this change?

It's already in place and taking advantage of autogeneration

@dicolanl
Copy link
Contributor Author

dicolanl commented Mar 2, 2022

Yes, we did and dicussed moving to autogeneration mode

When you plan to do this change?

to add more context. we talked with Damien awhile ago. we were waiting on the RP to create a new set of APIs, which they have now released. so we wanted to move to this model as the RP plans to release updates monthly to the API and autogeneration will make it easier to keep POSH up to date.

@BethanyZhou
Copy link
Contributor

Got it. Please go ahead.

@BethanyZhou
Copy link
Contributor

Hi @dicolanl , could you please submit a design review for new generated cmdlets at https://github.com/Azure/azure-powershell-cmdlet-review-pr?

@dicolanl
Copy link
Contributor Author

dicolanl commented Mar 8, 2022

@tianderturpijn will need to do it. I can't see that repo.

@BethanyZhou
Copy link
Contributor

Could you please join Azure organization on GitHub. I think you can access after that.

@anat-gilenson
Copy link

@BethanyZhou the design review was recently accepted: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1161. Is it possible to merge this PR?
Thank you!

@anat-gilenson
Copy link

@VeryEarly Are there any more steps we need to take for this PR? When can the PR be merged? When will there be a new release?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants