Skip to content

Conversation

@shyamshd
Copy link
Member

@shyamshd shyamshd commented Jun 16, 2020

Description

  • Put/Delete hubvnet operations were using PUT on parent hub. Instead just use the newly exposed put/delete APIs on hubvnet connection.
  • Use hubvnet connections crud operations in virtual hub cmdlets also. The virtual network connections here will be eventually deprecated. Add a warning to that effect.
  • In, New hubvnet command, make enableInternetSecurity to be true by default unless specified otherwise. Since the parameter was previously a switch, add a deprecation warning for the old one and add a new flag.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@shyamshd shyamshd requested a review from anton-evseev as a code owner June 16, 2020 06:12
Shyam Dharmarajan added 6 commits June 15, 2020 23:18
Put/Delete hubvnet operations were using PUT on parent hub. Instead just
use the newly exposed put/delete APIs on hubvnet connection.

Set EnableInternetSecurity flag to true by default.  Do this only for
new connections
This retains backward compatibility with the existing virtual hub APIs.
Also add a deprecation warning to remove specifying virtualnetwork
connections in virtual hub.
Update with review comments.
- Fix deprecation error message
- Update ChangeLog.md
@shyamshd shyamshd force-pushed the master-deprecate-hubvnet-conn-from-hub branch from 1e07a92 to d3f4f07 Compare June 16, 2020 06:24
@VeryEarly VeryEarly self-assigned this Jun 16, 2020
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants