VirtualWan: Use hubvnet CRUD operations for Hubvnet and hub cmdlets #12009

shyamshd · 2020-05-28T04:30:46Z

Description

Put/Delete hubvnet operations were using PUT on parent hub. Instead just use the newly exposed put/delete APIs on hubvnet connection.
Use hubvnet connections crud operations in virtual hub cmdlets also. The virtual network connections here will be eventually deprecated. Add a warning to that effect.
In, New hubvnet command, make enableInternetSecurity to be true by default unless specified otherwise. Since the parameter was previously a switch, add a deprecation warning for the old one and add a new flag.

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
- the markdown help files have been regenerated using the commands listed here

Put/Delete hubvnet operations were using PUT on parent hub. Instead just use the newly exposed put/delete APIs on hubvnet connection. Set EnableInternetSecurity flag to true by default. Do this only for new connections

This retains backward compatibility with the existing virtual hub APIs. Also add a deprecation warning to remove specifying virtualnetwork connections in virtual hub.

* lb backend address pool create/update/delete operations * adding tests with draft * making some updates for design review PR to powershell team * adding .md files * -adding tests -updating help files -addressing feedback * pulling in sdk changes for network-may branch for validation errors * Addressing comments and updating output format for PsLoadBalancerBackendAddress * updating .md files and making final changes Co-authored-by: Ali Egal <[email protected]>

VeryEarly · 2020-06-01T04:59:46Z

Hi @Shyamal-V

Besides the review from @nagula-ritvika , it seems like there are build issue caused by SDK, please resolve inorder to pass CI checks

shyamshd · 2020-06-01T06:41:07Z

Hi @Shyamal-V

Besides the review from @nagula-ritvika , it seems like there are build issue caused by SDK, please resolve inorder to pass CI checks

The build issues are because the SDK is not available yet. I built/tested it by creating a local SDK. The rest-api changes have been merged. I was told the new 2020-05-01 api version should be available this week. I uploaded it sooner to give the reviewers enough time.

VeryEarly · 2020-06-01T06:43:04Z

Hi @Shyamal-V
Besides the review from @nagula-ritvika , it seems like there are build issue caused by SDK, please resolve inorder to pass CI checks

The build issues are because the SDK is not available yet. I built/tested it by creating a local SDK. The rest-api changes have been merged. I was told the new 2020-05-01 api version should be available this week. I uploaded it sooner to give the reviewers enough time.

Please let me know once it was available, thanks.

…P2SVpnGateway and P2SClients (Azure#12006) * Adding new optional parameter to specify dns servers for Virtual Wan-P2SVpnGateway and P2SClients * Incorporate code review comments and added test record * Suppress warnings * Suppress cred scan errors

shyamshd · 2020-06-03T15:51:16Z

@VeryEarly do you know when the new SDK would become available? Also, how do I trigger the pipeline to run again when it becomes available?

VeryEarly · 2020-06-03T22:12:52Z

@VeryEarly do you know when the new SDK would become available? Also, how do I trigger the pipeline to run again when it becomes available?

SDK generation should be handled by service team.
You can do "/azp run" to restart the CI.

shyamshd · 2020-06-05T04:36:38Z

/azp run

Co-authored-by: Ali Egal <[email protected]>

…ly (Azure#12076)

nagula-ritvika

lgtm : please update help markdown files and have PR ready for review by PS team by the time sdk is merged in

src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubCommand.cs

src/Network/Network/Cortex/VirtualHub/UpdateAzureRmVirtualHubCommand.cs

src/Network/Network/Cortex/VirtualHub/VirtualHubBaseCmdlet.cs

* commit1 * commit2 * Fix1 Co-authored-by: Khushboo Baheti <[email protected]>

…or Multiple DNAT Rule Collections (Azure#12095) * Change RuleGroup and RuleCollectionGroup based on swagger change. Also, add support for NAT Rule Collections containing multiple NAT Rule Collections * PR Comments * Updated the SDK * StaticAnalysis * Previous changes got removed in rebase

* Use Network SDK from NuGet * Additional mappings

…thub.com/shyamshd/azure-powershell into shdharma/deprecate-hubvnet-conn-from-hub

…ting error

* merge conflict * fixes * tejas review Co-authored-by: Ishani Gupta <[email protected]>

* Add support for IPGroups in Firewall Policy Rules * Pr Comments * Resolved merge conflicts * Update ChangeLog.md * Update ChangeLog.md Co-authored-by: Yabo Hu <[email protected]>

shyamshd · 2020-06-12T19:35:57Z

@VeryEarly I updated the test cases, but I am still running into an issue. It is unrelated to my change and in express route. Do we know if the test passes in the baseline without my changes?

Also another question- Is there a way to run the pipeline with a different resource name and/or in a different region. I tried to debug the ER gateway failure & I suspect it might be to do with some zombie state related to this specific resource in the specific region.

PR : Update to accomdate SDK changes with VNET reference

* Application Gateway Private Link Cmdlets * add change log

shyamshd · 2020-06-14T05:25:17Z

/azp run

azure-pipelines · 2020-06-14T05:25:35Z

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly · 2020-06-15T04:23:01Z

@VeryEarly I updated the test cases, but I am still running into an issue. It is unrelated to my change and in express route. Do we know if the test passes in the baseline without my changes?

Also another question- Is there a way to run the pipeline with a different resource name and/or in a different region. I tried to debug the ER gateway failure & I suspect it might be to do with some zombie state related to this specific resource in the specific region.

This test case referenced New-AzVirtualHub which has API changed, please investigate and fix test case.

https://github.com/shyamshd/azure-powershell/blob/shdharma/deprecate-hubvnet-conn-from-hub/src/Network/Network.Test/ScenarioTests/VirtualHubRouteTableTests.ps1#L47

* add routing state and expose reset-hubrouter * update help * updated * Update ChangeLog.md * update help file name * export cmdlet * update test * fix * update md file * update tests * updated help * Update Reset-AzHubRouter.md * test recorded Co-authored-by: Yabo Hu <[email protected]>

VeryEarly · 2020-06-15T06:28:18Z

/azp run

azure-pipelines · 2020-06-15T06:28:36Z

Azure Pipelines successfully started running 3 pipeline(s).

The base branch was changed.

VeryEarly · 2020-06-17T02:26:24Z

close as merged in another PR #12171

Shyam Dharmarajan added 2 commits May 27, 2020 00:53

Vwan: Use hubvnet rest API for Hubvnet operations

30533a9

Put/Delete hubvnet operations were using PUT on parent hub. Instead just use the newly exposed put/delete APIs on hubvnet connection. Set EnableInternetSecurity flag to true by default. Do this only for new connections

Vwan: Use hubvnet CRUD api in virtual hub too

ec29a9e

This retains backward compatibility with the existing virtual hub APIs. Also add a deprecation warning to remove specifying virtualnetwork connections in virtual hub.

shyamshd requested a review from anton-evseev as a code owner May 28, 2020 04:30

shyamshd changed the title ~~Shdharma/deprecate hubvnet conn from hub~~ VirtualWan: Use hubvnet CRUD operations for Hubvnet and hub cmdlets May 28, 2020

shyamshd requested a review from nagula-ritvika May 28, 2020 04:32

VeryEarly self-assigned this May 28, 2020

shyamshd mentioned this pull request May 28, 2020

VWan:: Hub virtual network connection related changes Azure/azure-cli#13715

Closed

VeryEarly added the Waiting for CI label Jun 1, 2020

nagula-ritvika assigned nagula-ritvika and unassigned nagula-ritvika Jun 5, 2020

aegal and others added 6 commits June 5, 2020 14:54

updating help files examples (Azure#12068)

b242a55

Co-authored-by: Ali Egal <[email protected]>

multipip changes

10c3779

Do not pass new fields with default values unless configured explicit…

b7c50ca

…ly (Azure#12076)

multi pip changes

8facadd

ps tests

e906963

generating help files

692ca3e

nagula-ritvika previously approved these changes Jun 9, 2020

View reviewed changes

saisujithreddym added 5 commits June 8, 2020 18:22

help files changes

22d59d3

help file

f8d8dbe

regenerating help files

9b139a7

updated markdown file

d7965e9

renaming the cmdlets

f580e30

Khushboo-Baheti and others added 10 commits June 11, 2020 09:59

Vpn gateway commandlet update (Azure#12108)

063dec1

* commit1 * commit2 * Fix1 Co-authored-by: Khushboo Baheti <[email protected]>

Use Network SDK from NuGet (Azure#12114)

0706e06

* Use Network SDK from NuGet * Additional mappings

Vwan hubvnet connection changes: Update help files

e89a8c2

Merge branch 'shdharma/deprecate-hubvnet-conn-from-hub' of https://gi…

148453b

…thub.com/shyamshd/azure-powershell into shdharma/deprecate-hubvnet-conn-from-hub

Merge branch 'network-may' into updateVnetReference

e211b12

updating due to validation error on CICD pipeline

56297c4

refreshing test files, updating to remove id from variable to fix cas…

b44bafe

…ting error

DNS Proxy in Firewall Policy (Azure#12120)

f7b324f

* merge conflict * fixes * tejas review Co-authored-by: Ishani Gupta <[email protected]>

Add support for IPGroups in Firewall Policy Rules (Azure#12118)

82068e2

* Add support for IPGroups in Firewall Policy Rules * Pr Comments * Resolved merge conflicts * Update ChangeLog.md * Update ChangeLog.md Co-authored-by: Yabo Hu <[email protected]>

aegal and others added 2 commits June 12, 2020 16:29

Merge pull request Azure#12117 from Azure/updateVnetReference

f6b8af1

PR : Update to accomdate SDK changes with VNET reference

Application Gateway Private Link Cmdlets (Azure#12133)

27661df

* Application Gateway Private Link Cmdlets * add change log

Vwan hubvnet connection changes: Update test

3575979

shyamshd force-pushed the shdharma/deprecate-hubvnet-conn-from-hub branch from b07761a to 3575979 Compare June 15, 2020 08:32

azuresdkci added the needs-review label Jun 15, 2020

Shyam Dharmarajan added 2 commits June 15, 2020 09:40

Merge branch 'network-may' into shdharma/deprecate-hubvnet-conn-from-hub

6c65204

Update newly added test.

6548e64

VeryEarly removed Waiting for CI needs-review labels Jun 16, 2020

VeryEarly changed the base branch from network-may to master June 16, 2020 05:30

VeryEarly closed this Jun 17, 2020

VirtualWan: Use hubvnet CRUD operations for Hubvnet and hub cmdlets #12009

VirtualWan: Use hubvnet CRUD operations for Hubvnet and hub cmdlets #12009

Uh oh!

Conversation

shyamshd commented May 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

VeryEarly commented Jun 1, 2020

Uh oh!

shyamshd commented Jun 1, 2020

Uh oh!

VeryEarly commented Jun 1, 2020

Uh oh!

shyamshd commented Jun 3, 2020

Uh oh!

VeryEarly commented Jun 3, 2020

Uh oh!

shyamshd commented Jun 5, 2020

Uh oh!

nagula-ritvika left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shyamshd commented Jun 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shyamshd commented Jun 14, 2020

Uh oh!

azure-pipelines bot commented Jun 14, 2020

Uh oh!

VeryEarly commented Jun 15, 2020

Uh oh!

VeryEarly commented Jun 15, 2020

Uh oh!

azure-pipelines bot commented Jun 15, 2020

Uh oh!

VeryEarly commented Jun 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

shyamshd commented May 28, 2020 •

edited

Loading

shyamshd commented Jun 12, 2020 •

edited

Loading