Skip to content

[Storage] Update to SRP SDK 14.2.0, and add Quota parameter alias #10655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VeryEarly merged 3 commits into from
Dec 5, 2019
Merged

[Storage] Update to SRP SDK 14.2.0, and add Quota parameter alias #10655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17bce11
[Storage] Update to SRP SDK 14.2.0, and add Quota parameter alias
blueww Dec 4, 2019
cceebcd
[Storage] Update help to File share quota alias
blueww Dec 4, 2019
c83d745
[Storage] Remove the temp private package
blueww Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EventGrid/EventGrid.Test/EventGrid.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<PackageReference Include="Microsoft.Azure.Management.EventHub" Version="2.5.0" />
<PackageReference Include="Microsoft.Azure.Management.Relay" Version="2.0.2" />
<PackageReference Include="Microsoft.Azure.Management.ServiceBus" Version="2.1.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="14.1.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="14.2.0" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/Storage/Storage.Management.Test/Storage.Management.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="14.1.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="14.2.0" />
</ItemGroup>

</Project>
6 changes: 4 additions & 2 deletions src/Storage/Storage.Management/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@
- New-AzStorageBlobSASToken
* Support revoke Storage Account User Delegation Keys, so all Idenity SAS tokens are revoked
- Revoke-AzStorageAccountUserDelegationKeys
* Upgrade to Microsoft.Azure.Management.Storage 14.1.0, to support new API version 2019-06-01.
* Support Share QuotaGiB more than 5120, in Management plane File Share cmdlets
* Upgrade to Microsoft.Azure.Management.Storage 14.2.0, to support new API version 2019-06-01.
* Support Share QuotaGiB more than 5120 in Management plane File Share cmdlets, and add parameter alias "Quota" to parameter "QuotaGiB"
- New-AzRmStorageShare
- Update-AzRmStorageShare
* Add parameter alias "QuotaGiB" to parameter "Quota"
- Set-AzStorageShareQuota
* Fix the issue that Set-AzStorageContainerAcl can clean up the stored Access Policy
- Set-AzStorageContainerAcl

Expand Down
1 change: 1 addition & 0 deletions src/Storage/Storage.Management/File/NewAzureStorageShare.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ public class NewAzureStorageShareCommand : StorageFileBaseCmdlet
[ValidateNotNullOrEmpty]
public string Name { get; set; }

[Alias("Quota")]
[Parameter(Mandatory = false,
HelpMessage = "Share Quota in Gibibyte.")]
public int QuotaGiB
Expand Down
1 change: 1 addition & 0 deletions src/Storage/Storage.Management/File/UpdateAzureStorageShare.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ public class UpdateAzureStorageShareCommand : StorageFileBaseCmdlet
[ValidateNotNullOrEmpty]
public PSShare InputObject { get; set; }

[Alias("Quota")]
[Parameter(Mandatory = false,
HelpMessage = "Share Quota in Gibibyte.")]
public int QuotaGiB
Expand Down
2 changes: 1 addition & 1 deletion src/Storage/Storage.Management/Storage.Management.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<RootNamespace>$(LegacyAssemblyPrefix)$(PsModuleName)</RootNamespace>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="14.1.0" />
<PackageReference Include="Microsoft.Azure.Management.Storage" Version="14.2.0" />
<PackageReference Include="Microsoft.Azure.Storage.Blob" Version="11.1.0" />
<PackageReference Include="Microsoft.Azure.Storage.File" Version="11.1.0" />
<PackageReference Include="Microsoft.Azure.Storage.Queue" Version="11.1.0" />
Expand Down
8 changes: 4 additions & 4 deletions src/Storage/Storage.Management/help/Get-AzRmStorageShare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ Aliases: N, ShareName
Required: False
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand All @@ -112,7 +112,7 @@ Aliases:
Required: True
Position: 0
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand Down Expand Up @@ -142,7 +142,7 @@ Aliases:
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: True (ByValue)
Accept wildcard characters: False
```

Expand All @@ -157,7 +157,7 @@ Aliases: AccountName
Required: True
Position: 1
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand Down
14 changes: 7 additions & 7 deletions src/Storage/Storage.Management/help/New-AzRmStorageShare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ PS C:\>New-AzRmStorageShare -ResourceGroupName "myResourceGroup" -StorageAccount

Name StorageAccountName ResourceGroupName Etag QuotaGiB LastModifiedTime
---- ------------------ ----------------- ---- -------- ----------------
myshare myStorageAccount myResourceGroup
myshare myStorageAccount myResourceGroup
```

This command creates a Storage file share with metadata and share quota as 100 GiB.
Expand All @@ -47,7 +47,7 @@ Get-AzStorageAccount -ResourceGroupName "myResourceGroup" -StorageAccountName "m

Name StorageAccountName ResourceGroupName Etag QuotaGiB LastModifiedTime
---- ------------------ ----------------- ---- -------- ----------------
myshare myStorageAccount myResourceGroup
myshare myStorageAccount myResourceGroup
```

This command creates a Storage file share with Storage account object and share name.
Expand Down Expand Up @@ -95,7 +95,7 @@ Aliases: N, ShareName
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand All @@ -105,7 +105,7 @@ Share Quota in Gibibyte.
```yaml
Type: System.Int32
Parameter Sets: (All)
Aliases:
Aliases: Quota

Required: False
Position: Named
Expand All @@ -125,7 +125,7 @@ Aliases:
Required: True
Position: 0
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand All @@ -140,7 +140,7 @@ Aliases:
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: True (ByValue)
Accept wildcard characters: False
```

Expand All @@ -155,7 +155,7 @@ Aliases: AccountName
Required: True
Position: 1
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand Down
10 changes: 5 additions & 5 deletions src/Storage/Storage.Management/help/Remove-AzRmStorageShare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Aliases: Share
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: True (ByValue)
Accept wildcard characters: False
```

Expand All @@ -121,7 +121,7 @@ Aliases: N, ShareName
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand Down Expand Up @@ -152,7 +152,7 @@ Aliases:
Required: True
Position: 0
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand Down Expand Up @@ -182,7 +182,7 @@ Aliases:
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: True (ByValue)
Accept wildcard characters: False
```

Expand All @@ -197,7 +197,7 @@ Aliases: AccountName
Required: True
Position: 1
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand Down
2 changes: 1 addition & 1 deletion src/Storage/Storage.Management/help/Set-AzStorageShareQuota.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ See the quota limitation in https://docs.microsoft.com/en-us/azure/azure-subscri
```yaml
Type: System.Int32
Parameter Sets: (All)
Aliases:
Aliases: QuotaGiB

Required: True
Position: 1
Expand Down
12 changes: 6 additions & 6 deletions src/Storage/Storage.Management/help/Update-AzRmStorageShare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Aliases: Share
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: True (ByValue)
Accept wildcard characters: False
```

Expand Down Expand Up @@ -140,7 +140,7 @@ Aliases: N, ShareName
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand All @@ -150,7 +150,7 @@ Share Quota in Gibibyte.
```yaml
Type: System.Int32
Parameter Sets: (All)
Aliases:
Aliases: Quota

Required: False
Position: Named
Expand All @@ -170,7 +170,7 @@ Aliases:
Required: True
Position: 0
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand Down Expand Up @@ -200,7 +200,7 @@ Aliases:
Required: True
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName, ByValue)
Accept pipeline input: True (ByValue)
Accept wildcard characters: False
```

Expand All @@ -215,7 +215,7 @@ Aliases: AccountName
Required: True
Position: 1
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept pipeline input: False
Accept wildcard characters: False
```

Expand Down
1 change: 1 addition & 0 deletions src/Storage/Storage/File/Cmdlet/SetAzureStorageShareQuota.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public class SetAzureStorageShareQuota : AzureStorageFileCmdletBase
[ValidateNotNull]
public CloudFileShare Share { get; set; }

[Alias("QuotaGiB")]
[Parameter(Position = 1, Mandatory = true,
HelpMessage = "Share Quota")]
public int Quota { get; set; }
Expand Down