-
Notifications
You must be signed in to change notification settings - Fork 97
vnext regen resources, fix api-version method parameter #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c34e4e4
regen resources
weidongxu-microsoft f41345a
remove fixme
weidongxu-microsoft 0ca0444
convert GenericResourceExtendedInner to GenericResourceInner
weidongxu-microsoft ef494a5
update record
weidongxu-microsoft 75dc02c
sync with track1
weidongxu-microsoft 6f5a97d
regen resources with fix on docstring
weidongxu-microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
azure-mgmt-resources/src/main/java/com/azure/management/resources/AliasPathType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
azure-mgmt-resources/src/main/java/com/azure/management/resources/AliasType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
azure-mgmt-resources/src/main/java/com/azure/management/resources/BasicDependency.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
azure-mgmt-resources/src/main/java/com/azure/management/resources/ChangeType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
azure-mgmt-resources/src/main/java/com/azure/management/resources/CloudError.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
azure-mgmt-resources/src/main/java/com/azure/management/resources/DebugSetting.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
azure-mgmt-resources/src/main/java/com/azure/management/resources/Dependency.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
...mgmt-resources/src/main/java/com/azure/management/resources/DeploymentExtendedFilter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
azure-mgmt-resources/src/main/java/com/azure/management/resources/DeploymentMode.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for | ||
| // license information. | ||
| // | ||
| // Licensed under the MIT License. | ||
| // Code generated by Microsoft (R) AutoRest Code Generator. | ||
|
|
||
| package com.azure.management.resources; | ||
|
|
@@ -24,7 +22,8 @@ public class DeploymentProperties { | |
| private Object template; | ||
|
|
||
| /* | ||
| * Entity representing the reference to the template. | ||
| * The URI of the template. Use either the templateLink property or the | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this change caused by generator change also?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. I think it is from changes by modelerfour. Not confirmed. |
||
| * template property, but not both. | ||
| */ | ||
| @JsonProperty(value = "templateLink") | ||
| private TemplateLink templateLink; | ||
|
|
@@ -40,7 +39,9 @@ public class DeploymentProperties { | |
| private Object parameters; | ||
|
|
||
| /* | ||
| * Entity representing the reference to the deployment parameters. | ||
| * The URI of parameters file. You use this element to link to an existing | ||
| * parameters file. Use either the parametersLink property or the | ||
| * parameters property, but not both. | ||
| */ | ||
| @JsonProperty(value = "parametersLink") | ||
| private ParametersLink parametersLink; | ||
|
|
@@ -58,13 +59,13 @@ public class DeploymentProperties { | |
| private DeploymentMode mode; | ||
|
|
||
| /* | ||
| * The debug setting. | ||
| * The debug setting of the deployment. | ||
| */ | ||
| @JsonProperty(value = "debugSetting") | ||
| private DebugSetting debugSetting; | ||
|
|
||
| /* | ||
| * Deployment on error behavior. | ||
| * The deployment on error behavior. | ||
| */ | ||
| @JsonProperty(value = "onErrorDeployment") | ||
| private OnErrorDeployment onErrorDeployment; | ||
|
|
@@ -98,8 +99,8 @@ public DeploymentProperties setTemplate(Object template) { | |
| } | ||
|
|
||
| /** | ||
| * Get the templateLink property: Entity representing the reference to the | ||
| * template. | ||
| * Get the templateLink property: The URI of the template. Use either the | ||
| * templateLink property or the template property, but not both. | ||
| * | ||
| * @return the templateLink value. | ||
| */ | ||
|
|
@@ -108,8 +109,8 @@ public TemplateLink getTemplateLink() { | |
| } | ||
|
|
||
| /** | ||
| * Set the templateLink property: Entity representing the reference to the | ||
| * template. | ||
| * Set the templateLink property: The URI of the template. Use either the | ||
| * templateLink property or the template property, but not both. | ||
| * | ||
| * @param templateLink the templateLink value to set. | ||
| * @return the DeploymentProperties object itself. | ||
|
|
@@ -150,8 +151,9 @@ public DeploymentProperties setParameters(Object parameters) { | |
| } | ||
|
|
||
| /** | ||
| * Get the parametersLink property: Entity representing the reference to | ||
| * the deployment parameters. | ||
| * Get the parametersLink property: The URI of parameters file. You use | ||
| * this element to link to an existing parameters file. Use either the | ||
| * parametersLink property or the parameters property, but not both. | ||
| * | ||
| * @return the parametersLink value. | ||
| */ | ||
|
|
@@ -160,8 +162,9 @@ public ParametersLink getParametersLink() { | |
| } | ||
|
|
||
| /** | ||
| * Set the parametersLink property: Entity representing the reference to | ||
| * the deployment parameters. | ||
| * Set the parametersLink property: The URI of parameters file. You use | ||
| * this element to link to an existing parameters file. Use either the | ||
| * parametersLink property or the parameters property, but not both. | ||
| * | ||
| * @param parametersLink the parametersLink value to set. | ||
| * @return the DeploymentProperties object itself. | ||
|
|
@@ -204,7 +207,7 @@ public DeploymentProperties setMode(DeploymentMode mode) { | |
| } | ||
|
|
||
| /** | ||
| * Get the debugSetting property: The debug setting. | ||
| * Get the debugSetting property: The debug setting of the deployment. | ||
| * | ||
| * @return the debugSetting value. | ||
| */ | ||
|
|
@@ -213,7 +216,7 @@ public DebugSetting getDebugSetting() { | |
| } | ||
|
|
||
| /** | ||
| * Set the debugSetting property: The debug setting. | ||
| * Set the debugSetting property: The debug setting of the deployment. | ||
| * | ||
| * @param debugSetting the debugSetting value to set. | ||
| * @return the DeploymentProperties object itself. | ||
|
|
@@ -224,7 +227,7 @@ public DeploymentProperties setDebugSetting(DebugSetting debugSetting) { | |
| } | ||
|
|
||
| /** | ||
| * Get the onErrorDeployment property: Deployment on error behavior. | ||
| * Get the onErrorDeployment property: The deployment on error behavior. | ||
| * | ||
| * @return the onErrorDeployment value. | ||
| */ | ||
|
|
@@ -233,7 +236,7 @@ public OnErrorDeployment getOnErrorDeployment() { | |
| } | ||
|
|
||
| /** | ||
| * Set the onErrorDeployment property: Deployment on error behavior. | ||
| * Set the onErrorDeployment property: The deployment on error behavior. | ||
| * | ||
| * @param onErrorDeployment the onErrorDeployment value to set. | ||
| * @return the DeploymentProperties object itself. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we apply this change to all existing files in different modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get some script to do this. Maybe later when someone finished more important tasks...
Currently newly generated code will use this short style.