vnext regen resources, fix api-version method parameter#1126
vnext regen resources, fix api-version method parameter#1126weidongxu-microsoft merged 6 commits intovnextfrom
Conversation
weidongxu-microsoft
requested review from
ChenTanyi,
xseeseesee and
yungezz
as code owners
weidongxu-microsoft
changed the title
| // Licensed under the MIT License. See License.txt in the project root for | ||
| // license information. | ||
| // | ||
| // Licensed under the MIT License. |
There was a problem hiding this comment.
Should we apply this change to all existing files in different modules?
There was a problem hiding this comment.
We can get some script to do this. Maybe later when someone finished more important tasks...
Currently newly generated code will use this short style.
|
PR on spec Azure/azure-rest-api-specs#8803 |
|
Fix #1084 |
|
|
||
| /* | ||
| * Entity representing the reference to the template. | ||
| * The URI of the template. Use either the templateLink property or the |
There was a problem hiding this comment.
is this change caused by generator change also?
There was a problem hiding this comment.
Yes. I think it is from changes by modelerfour. Not confirmed.
| public PagedIterable<Deployment> listByResourceGroup(String groupName) { | ||
| // FIXME: filter & top parameter | ||
| return this.manager().inner().deployments().listByResourceGroup(groupName, null, null).mapPage(inner -> createFluentModel(inner)); | ||
| return this.manager().inner().deployments().listByResourceGroup(groupName).mapPage(inner -> createFluentModel(inner)); |
There was a problem hiding this comment.
just confirm, this is change from generator
There was a problem hiding this comment.
Actually this is Impl change.
The resources RP is among the 1st to migrate. Hence there remains quite some TODO/FIXME.
The method call is actually same, but older generator does not generate the method with default parameters (hence the 2 nulls need to be written explicitly in code before).
3 participants
fix #1084