Patch regression in ExternalEvent History-search #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2022
davidmrdavid
changed the title
michaelpeng36
approved these changes
Sep 6, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 7, 2022
* patch external events * add test * fix typo * relax test requirements
davidmrdavid
added a commit
that referenced
this pull request
Sep 7, 2022
* patch external events * add test * fix typo * relax test requirements
davidmrdavid
added a commit
that referenced
this pull request
Sep 8, 2022
davidmrdavid
added a commit
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears a recent external contribution (#786) accidentally broke the logic we use to retrieve external-event results from the History. In particular, it changed our History filtering condition to utilize
History.IsPlayed(which we do not control) instead ofHistory.IsProcessed(which we manage ourselves in the SDK). The result is that theStartExternalEventListenercommandlet may fail if a user schedules any activities beneath it.There's some relationship between
IsPlayedandIsProcessedso I'm not surprised that we didn't catch this during review. To ensure this doesn't regress again, I've added a test against this edge-case.Issue describing the changes in this PR
related: #851
Pull request checklist
release_notes.mdAdditional information
Additional PR information