Add Get-TaskResult CmdLet for DF #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Greg Roll <[email protected]>
…hell-worker into dajusto/external-contrib-get-taskResult
davidmrdavid
changed the title
davidmrdavid
requested review from
AnatoliB,
michaelpeng36 and
Francisco-Gamino
and removed request for
AnatoliB
|
@davidmrdavid Please add a work item to document the new cmdlet. |
AnatoliB
reviewed
Apr 15, 2022
| @@ -235,6 +235,8 @@ function New-DurableOrchestrationCheckStatusResponse { | |||
| The TaskHubName of the orchestration instance that will handle the external event. | |||
| .PARAMETER ConnectionName | |||
| The name of the connection string associated with TaskHubName | |||
| .PARAMETER AppCode | |||
There was a problem hiding this comment.
These changes do not seem to be related to the declared PR goal. I will not be insisting on necessarily separating them, but I want us to be mindful of this.
There was a problem hiding this comment.
Good call, I forgot about this addition. At the very least, I should have called this out. I'll keep an eye out in the future
AnatoliB
approved these changes
Apr 15, 2022
|
Added documentation issue here: #797 |
davidmrdavid
added a commit
that referenced
this pull request
Apr 18, 2022
Co-authored-by: Greg Roll <[email protected]>
davidmrdavid
added a commit
that referenced
this pull request
Apr 18, 2022
Co-authored-by: Greg Roll <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Related to #685 and #753
Currently, users do not have a way of obtaining the result of a DF Task that has already completed. This means that if a user did not assign a Task onto a variable when first invoking it, then they have no way of accessing its result.
This is an urgently missing feature and user oobegreg is proposing a CmdLet named Get-DurableTaskResult that allows us to do just that.
In general, this serves the purpose of performing an await (or yield in Python and JS) on a completed Durable Task, because in those languages re-awaiting a completed Task is a supported means of extracting that Task's result. Another way to do this is to expose a .result property on the DurableTask class and have users access that. However, I think this CmdLet-based approach is also sound, and I don't see why we couldn't have both given that users in other PLs can both access their classes' .result property and call yield/await for the same effect.
Pull request checklist
Get-TaskResultCmdLet #797release_notes.mdAdditional information
This needs a documentation update (to announce the new CmdLet) and also needs to be backported to all DF-supported branches.
Where should this documentation issue requested by the PR checklist be created? In the azure docs repo? I suppose that we can create it in this repo as well, just checking for this group goes about it :-)