Skip to content

Fix History Event None Return #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 27, 2023
Merged

Fix History Event None Return #466

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2146b25
check activity return not none
nytian Nov 17, 2023
b40bc56
avoid long line
nytian Nov 17, 2023
bcf5008
add check for subo and event
nytian Nov 17, 2023
d691088
fix indent
nytian Nov 17, 2023
f1c84b6
update by review
nytian Nov 17, 2023
b2265cf
add unit test for call activity with none return
nytian Nov 17, 2023
6656114
update test
nytian Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions azure/durable_functions/models/TaskOrchestrationExecutor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,14 @@ def parse_history_event(directive_result):

# We provide the ability to deserialize custom objects, because the output of this
# will be passed directly to the orchestrator as the output of some activity
if event_type == HistoryEventType.SUB_ORCHESTRATION_INSTANCE_COMPLETED:
if (event_type == HistoryEventType.SUB_ORCHESTRATION_INSTANCE_COMPLETED and
directive_result.Result is not None):
return json.loads(directive_result.Result, object_hook=_deserialize_custom_object)
if event_type == HistoryEventType.TASK_COMPLETED:
if (event_type == HistoryEventType.TASK_COMPLETED and
directive_result.Result is not None):
return json.loads(directive_result.Result, object_hook=_deserialize_custom_object)
if event_type == HistoryEventType.EVENT_RAISED:
if (event_type == HistoryEventType.EVENT_RAISED and
directive_result.Result is not None):
# TODO: Investigate why the payload is in "Input" instead of "Result"
response = json.loads(directive_result.Input,
object_hook=_deserialize_custom_object)
Expand Down