Fix History Event None Return #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
reviewed
Nov 17, 2023
nytian
changed the title
cgillum
reviewed
Nov 17, 2023
Member
|
Can we add a test case that verifies the fix? |
davidmrdavid
requested changes
Nov 17, 2023
Collaborator
davidmrdavid
left a comment
davidmrdavid
left a comment
There was a problem hiding this comment.
The change looks good to me, but let's add a test as Chris noticed :) . Thank you for the quick prototype here.
Contributor
Author
|
Added unit test that an orchestrator schedules an activity function which can return None. Let me know if the naming or any changes is unclear. Thanks for the reviews again! @cgillum @davidmrdavid |
davidmrdavid
approved these changes
Nov 27, 2023
greenie-msft
pushed a commit
to greenie-msft/azure-functions-durable-python
that referenced
this pull request
Sep 25, 2025
* check activity return not none * avoid long line * add check for subo and event * fix indent * update by review * add unit test for call activity with none return * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #454
When the history event tasks return None, error will be thrown since
Nonecould not be passed to json.loads.Add the condition check for history event returns so that if the return is None, the python SDK will just pass
Noneto durable extension without json deserialization.