Skip to content

Handle empty-list in compound tasks #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidmrdavid merged 2 commits into from
Aug 30, 2021
Merged

Handle empty-list in compound tasks #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
157a930
handle empty-list in compound tasks
davidmrdavid Aug 24, 2021
54ebc30
format the code to pass linter
davidmrdavid Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions azure/durable_functions/models/Task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,9 @@ def __init__(self, tasks: List[TaskBase], compound_action_constructor=None):
self.completed_tasks: List[TaskBase] = []
self.children = tasks

if len(self.children) == 0:
self.state = TaskState.SUCCEEDED

def handle_completion(self, child: TaskBase):
"""Manage sub-task completion events.

Expand Down
13 changes: 13 additions & 0 deletions tests/orchestrator/test_task_any.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,19 @@ def generator_function(context):
except:
return "exception"

def generator_function_no_activity(context):
yield context.task_any([])
return "Done!"

def test_continues_on_zero_inner_tasks():
context_builder = ContextBuilder()
result = get_orchestration_state_result(
context_builder, generator_function_no_activity)
expected_state = base_expected_state("Done!")
expected_state._is_done = True
expected = expected_state.to_json()
assert_orchestration_state_equals(expected, result)

def test_continues_on_zero_results():
context_builder = ContextBuilder()
result = get_orchestration_state_result(
Expand Down