Skip to content

Handle empty-list in compound tasks #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2021
Merged

Handle empty-list in compound tasks #317

merged 2 commits into from
Aug 30, 2021

Conversation

@davidmrdavid
Copy link
Collaborator

@davidmrdavid davidmrdavid commented Aug 24, 2021 •
edited
Loading

Addresses: #315

This PR ensures that a compound task is not stuck in a Running state after receiving an empty list of tasks.

This allows the following snippet to make progress:

yield context.task_all([]) # would previously get stuck

@davidmrdavid davidmrdavid marked this pull request as ready for review August 24, 2021 18:01
@davidmrdavid davidmrdavid merged commit 11f2912 into dev Aug 30, 2021
@davidmrdavid davidmrdavid deleted the dajusto/handle-empty-list-in-compound-tasks branch August 30, 2021 17:09
@davidmrdavid davidmrdavid mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgillum cgillum cgillum approved these changes

@ConnorMcMahon ConnorMcMahon Awaiting requested review from ConnorMcMahon

@amdeel amdeel Awaiting requested review from amdeel

@bachuv bachuv Awaiting requested review from bachuv bachuv is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidmrdavid @cgillum