-
Notifications
You must be signed in to change notification settings - Fork 208
Change first character of Type property value of metadata bindings entries to lower case #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d29d238
camelCasing type property value working version.
kshyju 3d01613
Moved the StringExtension under a directory
kshyju ce4c8d9
Fixed a failing test in the correct fashion.
kshyju 31f0e1e
Moved 2 existing extension method classes under Extensions directory.…
kshyju 50515b3
Fixed functions.metadata file present in E2E tests, which is being us…
kshyju 34236bb
Added one more test input entry(allo lowercase) for the ToCamelCaseWo…
kshyju 8693f5b
Switched to existing "ToLowerFirstCharacter" extension to be consiste…
kshyju 015e1d3
Moved the ToLowerFirstCharacter call inside GetBindingType
kshyju 85e60a0
Updated the constant value instead of explicit lowercasing
kshyju d6c89ef
Merge branch 'main' into shkr/metadata-generation-camelcase
kshyju ff66812
Removed the unnecessary semi column added by merge
kshyju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| namespace Microsoft.Azure.Functions.Worker.Sdk | ||
| { | ||
| internal static class StringExtensions | ||
| { | ||
| /// <summary> | ||
| /// Returns a copy of the string in camelCase. | ||
| /// </summary> | ||
| public static string ToCamelCase(this string value) | ||
|
kshyju marked this conversation as resolved.
Outdated
|
||
| { | ||
| // Using the same logic as in JsonCamelCaseNamingPolicy(System.Text.Json) | ||
|
|
||
| if (string.IsNullOrEmpty(value) || !char.IsUpper(value[0])) | ||
| { | ||
| return value; | ||
| } | ||
|
|
||
| char[] chars = value.ToCharArray(); | ||
|
|
||
| for (int i = 0; i < chars.Length; i++) | ||
| { | ||
| if (i == 1) | ||
| { | ||
| if (!char.IsUpper(chars[i])) | ||
| { | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| bool hasNext = (i + 1 < chars.Length); | ||
|
|
||
| // Stop when next char is already lowercase. | ||
| if (i > 0 && hasNext && !char.IsUpper(chars[i + 1])) | ||
| { | ||
| // If the next char is a space, lowercase current char before exiting. | ||
| if (chars[i + 1] == ' ') | ||
| { | ||
| chars[i] = char.ToLowerInvariant(chars[i]); | ||
| } | ||
|
|
||
| break; | ||
| } | ||
|
|
||
| chars[i] = char.ToLowerInvariant(chars[i]); | ||
| } | ||
|
|
||
| return new string(chars); | ||
| } | ||
| } | ||
| } | ||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
test/FunctionMetadataGeneratorTests/StringExtensionsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using Microsoft.Azure.Functions.Worker.Sdk; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Azure.Functions.SdkTests | ||
| { | ||
| public class StringExtensionsTests | ||
| { | ||
| [Theory] | ||
| [InlineData("QueueTrigger", "queueTrigger")] | ||
| [InlineData("HTTPTrigger", "httpTrigger")] | ||
| [InlineData("Blob", "blob")] | ||
| [InlineData("", "")] | ||
| [InlineData(null, null)] | ||
| public void ToCamelCaseWorks(string input, string expectedOutput) | ||
| { | ||
| var actual = input.ToCamelCase(); | ||
|
|
||
| Assert.Equal(expectedOutput, actual); | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved 2 existing extension method classes under the new "Extensions" directory. They were in the root of the project earlier.