Skip to content

Change first character of Type property value of metadata bindings entries to lower case#589

Merged
kshyju merged 11 commits intomainfrom
shkr/metadata-generation-camelcase
Aug 31, 2021
Merged

Change first character of Type property value of metadata bindings entries to lower case#589
kshyju merged 11 commits intomainfrom
shkr/metadata-generation-camelcase

Conversation

@kshyju
Copy link
Copy Markdown
Member

@kshyju kshyju commented Aug 20, 2021

Fixes #555

The scaling infrastructure expects the Type property value in the bindings entries of functions.metadata to be in camelCase, for it to work correctly. This PR does that by converting that property value to camel case when generating the JSON content for the metadata file.

using System.Text;
using Mono.Cecil;

namespace Microsoft.Azure.Functions.Worker.Sdk
Copy link
Copy Markdown
Member Author

@kshyju kshyju Aug 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved 2 existing extension method classes under the new "Extensions" directory. They were in the root of the project earlier.

@kshyju kshyju requested a review from brettsam August 23, 2021 16:22
Comment thread sdk/Sdk/Extensions/StringExtensions.cs Outdated
@kshyju kshyju changed the title Change Type property value of metadata bindings entries to camelCase Change first character of Type property value of metadata bindings entries to lower case Aug 25, 2021
@kshyju kshyju requested a review from brettsam August 25, 2021 16:18
@kshyju kshyju merged commit 598d0b7 into main Aug 31, 2021
@kshyju kshyju deleted the shkr/metadata-generation-camelcase branch August 31, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata generation must convert values to camel casing

2 participants