Conversation
Member
|
@jviau it might be helpful to share a link for a diff against a branch with the state we had in 1.17.0 so we can focus on the delta. Is that something you can provide? |
jviau
commented
Mar 25, 2024
Contributor
Author
Here is a diff. It isn't very helpful though as it also includes every unrelated commit between the two as well. Do you know a way to get a cleaner diff? In the meantime, I can guide the review a bit here:
|
kshyju
reviewed
Mar 26, 2024
kshyju
approved these changes
Apr 3, 2024
Member
kshyju
left a comment
There was a problem hiding this comment.
Let's get the preview version out for E2E testing.
fabiocav
approved these changes
Apr 3, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
release_notes.mdAdditional information
This re-adds the SDK overhaul that was reverted in #2313. The cause for the reversion has also been addressed. The root issue was that we were identifying what referenced assemblies to scan by looking at all dll's next to the final output assembly of the functions project. With the SDK refactoring this was no longer possible as our targets ran earlier (before being copied to final output location). Instead, we directly use the
ReferencePathitem group from MSBuild to identify all assemblies that will be copied to the final output directory.