Merged
Conversation
…ence (which was removed due to revert)
satvu
approved these changes
Mar 1, 2024
jviau
added a commit
that referenced
this pull request
Mar 13, 2024
7 tasks
jviau
added a commit
that referenced
this pull request
Apr 3, 2024
* Revert "Reverting changes introduced in #1946 (#2313)" (#2346) This reverts commit c34a868. * Directly use ReferencePath for scanning reference assemblies * update release_notes.md * Update log message * Add e2e test to verify SDK assembly scanning * Include nuget.org for test * Pass https source first * Add package with no restore * Refactor Sdk e2e build steps * Remove --no-restore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting changes introduced in #1946 as we identified an issue where the
extension.jsongeneration was not respecting dependent assemblies.This change will be released as SDK 1.17.2
Pull request checklist
release_notes.md