Skip to content

Add DefaultValue attribute to Kafka trigger attribute's IsBatched prop #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satvu merged 3 commits into from
Dec 12, 2023
Merged

Add DefaultValue attribute to Kafka trigger attribute's IsBatched prop #2139

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b66acf9
add isBatched default value
satvu Dec 7, 2023
a004351
bump and add release notes
satvu Dec 7, 2023
13ea1f2
add kafka ut
satvu Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/Worker.Extensions.Kafka/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
- My change description (#PR/#issue)
-->

### Microsoft.Azure.Functions.Worker.Extensions.Kafka <version>
### Microsoft.Azure.Functions.Worker.Extensions.Kafka 3.10.1

- <entry>
- Add `DefaultValue` attribute to Kafka Trigger's `IsBatched` prop to signal default cardinality value to source generators (#2139)
1 change: 1 addition & 0 deletions extensions/Worker.Extensions.Kafka/src/KafkaTriggerAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ public KafkaTriggerAttribute(string brokerList, string topic)
/// <summary>
/// Gets or sets the configuration to enable batch processing of events. Default value is "false".
/// </summary>
[DefaultValue(false)]
public bool IsBatched
{
get => _isBatched;
Expand Down
2 changes: 1 addition & 1 deletion extensions/Worker.Extensions.Kafka/src/Worker.Extensions.Kafka.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Description>Kafka extensions for .NET isolated functions</Description>

<!--Version information-->
<VersionPrefix>3.10.0</VersionPrefix>
<VersionPrefix>3.10.1</VersionPrefix>

<!--Temporarily opting out of documentation. Pending documentation-->
<GenerateDocumentationFile>false</GenerateDocumentationFile>
Expand Down