Skip to content

Add DefaultValue attribute to Kafka trigger attribute's IsBatched prop#2139

Merged
satvu merged 3 commits intomainfrom
satvu/kafka-isbatched
Dec 12, 2023
Merged

Add DefaultValue attribute to Kafka trigger attribute's IsBatched prop#2139
satvu merged 3 commits intomainfrom
satvu/kafka-isbatched

Conversation

@satvu
Copy link
Copy Markdown
Member

@satvu satvu commented Dec 7, 2023

Issue describing the changes in this PR

resolves #2140

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Locally tested - cardinality is correctly populated in source-generated function metadata with this change.

@satvu satvu requested a review from kshyju December 7, 2023 19:38
@liliankasem
Copy link
Copy Markdown
Member

Is this a breaking change? Will this change the default behaviour of the kafka attribute?

Please also update release notes and ext version

@satvu
Copy link
Copy Markdown
Member Author

satvu commented Dec 7, 2023

Is this a breaking change? Will this change the default behaviour of the kafka attribute?

Please also update release notes and ext version

Added - this is not breaking or changing the default behavior because the DefaultValue attribute's value matches the one set here earlier in the file.

@satvu satvu requested a review from jainharsh98 December 7, 2023 22:49
@satvu satvu merged commit 423efb7 into main Dec 12, 2023
@satvu satvu deleted the satvu/kafka-isbatched branch December 12, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kafka Trigger IsBatched prop is missing "DefaultValue" attribute

4 participants