-
Notifications
You must be signed in to change notification settings - Fork 204
Handle self-contained application load #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,16 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using System.Diagnostics; | ||
| using System.Runtime.InteropServices; | ||
|
|
||
| namespace FunctionsNetHost | ||
| { | ||
| // If having problems with the managed host, enable the following: | ||
| // Environment.SetEnvironmentVariable("COREHOST_TRACE", "1"); | ||
| // In Unix environment, you need to run the below command in the terminal to set the environment variable. | ||
| // export COREHOST_TRACE=1 | ||
|
|
||
| /// <summary> | ||
| /// Manages loading hostfxr & worker assembly. | ||
| /// </summary> | ||
|
|
@@ -14,43 +20,36 @@ internal sealed class AppLoader : IDisposable | |
| private IntPtr _hostContextHandle = IntPtr.Zero; | ||
| private bool _disposed; | ||
|
|
||
| internal AppLoader() | ||
| internal int RunApplication(string? assemblyPath) | ||
| { | ||
| LoadHostfxrLibrary(); | ||
| } | ||
| ArgumentNullException.ThrowIfNull(assemblyPath, nameof(assemblyPath)); | ||
|
|
||
| private void LoadHostfxrLibrary() | ||
| { | ||
| // If having problems with the managed host, enable the following: | ||
| // Environment.SetEnvironmentVariable("COREHOST_TRACE", "1"); | ||
| // In Unix environment, you need to run the below command in the terminal to set the environment variable. | ||
| // export COREHOST_TRACE=1 | ||
| unsafe | ||
| { | ||
| var parameters = new NetHost.get_hostfxr_parameters | ||
| { | ||
| size = sizeof(NetHost.get_hostfxr_parameters), | ||
| assembly_path = GetCharArrayPointer(assemblyPath) | ||
| }; | ||
|
|
||
| var hostfxrFullPath = NetHost.GetHostFxrPath(); | ||
| Logger.LogTrace($"hostfxr path:{hostfxrFullPath}"); | ||
| var hostfxrFullPath = NetHost.GetHostFxrPath(¶meters); | ||
| Logger.LogTrace($"hostfxr path:{hostfxrFullPath}"); | ||
|
|
||
| _hostfxrHandle = NativeLibrary.Load(hostfxrFullPath); | ||
| if (_hostfxrHandle == IntPtr.Zero) | ||
| { | ||
| Logger.Log($"Failed to load hostfxr. hostfxr path:{hostfxrFullPath}"); | ||
| return; | ||
| } | ||
| _hostfxrHandle = NativeLibrary.Load(hostfxrFullPath); | ||
|
|
||
| Logger.LogTrace($"hostfxr library loaded successfully."); | ||
| } | ||
| if (_hostfxrHandle == IntPtr.Zero) | ||
| { | ||
| Logger.Log($"Failed to load hostfxr. hostfxrFullPath:{hostfxrFullPath}"); | ||
| return -1; | ||
| } | ||
|
|
||
| internal int RunApplication(string? assemblyPath) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(assemblyPath, nameof(assemblyPath)); | ||
| Logger.LogTrace($"hostfxr loaded."); | ||
|
|
||
| unsafe | ||
| { | ||
| var error = HostFxr.Initialize(1, new[] { assemblyPath }, IntPtr.Zero, out _hostContextHandle); | ||
|
|
||
| if (_hostContextHandle == IntPtr.Zero) | ||
| { | ||
| Logger.Log( | ||
| $"Failed to initialize the .NET Core runtime. Assembly path:{assemblyPath}"); | ||
| Logger.Log($"Failed to initialize the .NET Core runtime. Assembly path:{assemblyPath}"); | ||
| return -1; | ||
| } | ||
|
|
||
|
|
@@ -98,5 +97,14 @@ private void Dispose(bool disposing) | |
| _disposed = true; | ||
| } | ||
| } | ||
|
|
||
| private static unsafe char* GetCharArrayPointer(string assemblyPath) | ||
| { | ||
| #if OS_LINUX | ||
| return (char*)Marshal.StringToHGlobalAnsi(assemblyPath).ToPointer(); | ||
| #else | ||
| return (char*)Marshal.StringToHGlobalUni(assemblyPath).ToPointer(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be freed ( |
||
| #endif | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.