Merged
Conversation
Member
Author
|
@elinor-fung Could you please review this change? |
kshyju
commented
Nov 8, 2023
kshyju
commented
Nov 8, 2023
fabiocav
approved these changes
Nov 8, 2023
8 tasks
elinor-fung
reviewed
Nov 8, 2023
| #if OS_LINUX | ||
| return (char*)Marshal.StringToHGlobalAnsi(assemblyPath).ToPointer(); | ||
| #else | ||
| return (char*)Marshal.StringToHGlobalUni(assemblyPath).ToPointer(); |
Contributor
There was a problem hiding this comment.
This should be freed (Marshal.FreeHGlobal) after they are done being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FunctionsNetHost changes to handle self contained apps.
The major change is how we are getting the hostfxr path. Previously we were preload hostfxr in placeholder mode. With this change, we find the hostfxr path and load during cold start.
release_notes.md