Skip to content

Pass RestoreSources to inner-build restore task#1937

Merged
jviau merged 3 commits intoAzure:feature/ext-projfrom
jviau:restore-sources
Oct 3, 2023
Merged

Pass RestoreSources to inner-build restore task#1937
jviau merged 3 commits intoAzure:feature/ext-projfrom
jviau:restore-sources

Conversation

@jviau
Copy link
Copy Markdown
Contributor

@jviau jviau commented Sep 29, 2023

Issue describing the changes in this PR

resolves #1863

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

This is a more explicit fix to the linked issue. It is already addressed by moving the WorkerExtension.csproj out of the temp directory and into intermediate output dir (so it would inherit nuget.config), but I prefer directly supplying the nuget sources to use.

@jviau
Copy link
Copy Markdown
Contributor Author

jviau commented Oct 3, 2023

The CI linked to this was corrupted, a manual run succeeded: https://dev.azure.com/azfunc/Azure%20Functions/_build/results?buildId=154877&view=results

@jviau jviau merged commit 8f60c35 into Azure:feature/ext-proj Oct 3, 2023
@jviau jviau deleted the restore-sources branch October 3, 2023 20:53
jviau added a commit that referenced this pull request Jan 18, 2024
…d nuget feed issues (#1946)

* Worker Extension project incremental build support (#1749)

* Merge main to feature/ext-proj (#1832)

* Refactor SDK targets to address multiple writes and flaky builds (#1861)

* Ensure ExtensionsCsProjDirectory is a full path (#1938)

* Pass RestoreSources to inner-build restore task (#1937)

* Rev SDK version to 1.16.0-preview1 (#1941)

* Skip func targets during design time build (#1954)

* Correct merge mistakes

* Update sln

* Fix properties

* update worker.config.json generation (#2122)

* [SDK] Remove properties from inner-build (#2161)

* Expand on RemoveProperties for inner build. Fix source gen default

* Add PublishProfile to remove props

* Un-remove some properties from inner build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants