Refactor SDK targets to address multiple writes and flaky builds#1861
Merged
jviau merged 10 commits intoAzure:feature/ext-projfrom Sep 29, 2023
Merged
Refactor SDK targets to address multiple writes and flaky builds#1861jviau merged 10 commits intoAzure:feature/ext-projfrom
jviau merged 10 commits intoAzure:feature/ext-projfrom
Conversation
Contributor
Author
|
Actually, after reviewing the changes technically this is not breaking. The convention in MSBuild is any property, target, or item starting with |
liliankasem
approved these changes
Aug 31, 2023
brettsam
reviewed
Sep 27, 2023
brettsam
approved these changes
Sep 27, 2023
Member
brettsam
left a comment
There was a problem hiding this comment.
Reviewing these msbuild targets is tough! I think my only comment is that I'd like to see some comments sprinkled throughout the new Targets explaining what they're doing so it's easier for other folks to find the right place to update in the future.
jviau
added a commit
that referenced
this pull request
Jan 18, 2024
…d nuget feed issues (#1946) * Worker Extension project incremental build support (#1749) * Merge main to feature/ext-proj (#1832) * Refactor SDK targets to address multiple writes and flaky builds (#1861) * Ensure ExtensionsCsProjDirectory is a full path (#1938) * Pass RestoreSources to inner-build restore task (#1937) * Rev SDK version to 1.16.0-preview1 (#1941) * Skip func targets during design time build (#1954) * Correct merge mistakes * Update sln * Fix properties * update worker.config.json generation (#2122) * [SDK] Remove properties from inner-build (#2161) * Expand on RemoveProperties for inner build. Fix source gen default * Add PublishProfile to remove props * Un-remove some properties from inner build
This was referenced Oct 20, 2025
This was referenced Nov 10, 2025
This was referenced Dec 2, 2025
Open
Bump Azure.Identity and Microsoft.Azure.Functions.Worker.ApplicationInsights
louisledev/photosync#20
Closed
This was referenced Feb 15, 2026
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1834
Pull request checklist
release_notes.mdAdditional information
This PR is a near complete overhaul of our SDK targets. The aim of the changes is to integrate more closely with existing dotnet SDK targets to eliminate redundant work.
Copytasks have been removed and instead we augment specific item groups so thatCopyToOutputDirectoryandCopyToPublishDirectorytasks will copy our files for us.InputsandOutputs.extensions.jsonis always written to, so we always see it as changed and also write to it.IncrementalOutputPath. Only copying the final files in one go as part of the existingCopyToDirectoryDirectory(or publish dir).publish, we never actually callpublishon the innerWorkerExtensions.csproj. Instead, we can rely on the existing build targets and collecting of files to accomplish the same thing more efficiently.Concerns
This is a breaking change for anyone that has customized our targets. Hence the draft state. I am going to go through this and see if I can rename targets back to existing ones to minimize or eliminate the breaking change.See comment below