This repository was archived by the owner on Jan 28, 2022. It is now read-only.
Add golangci-lint and fixup flagged issues #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Azadehkhojandi
left a comment
Azadehkhojandi
left a comment
There was a problem hiding this comment.
Thank you so much for your PR, I had a few suggestions/questions.
|
|
||
| # Run go fmt against code | ||
| fmt: | ||
| go fmt ./... |
Contributor
There was a problem hiding this comment.
what was the reason of changing go fmt ./... to find . -name '*.go' | grep -v vendor | xargs gofmt -s -w?
Collaborator
Author
There was a problem hiding this comment.
the golangci-lint checks that the code has been simplified and I reused the fmt command from other projects to apply the simplification and to ignore vendored packages (avoids linter failures on those if vendoring is ever used)
stuartleeks
force-pushed
the
sl/add-linting
branch
3 times, most recently
from
70cb83c to
abb9853
Compare
Collaborator
Author
|
/azp list |
|
CI/CD Pipelines for this repository: |
stuartleeks
force-pushed
the
sl/add-linting
branch
from
abb9853 to
bda38cf
Compare
stuartleeks
force-pushed
the
sl/add-linting
branch
from
bda38cf to
2865b69
Compare
Azadehkhojandi
previously approved these changes
Nov 25, 2019
stuartleeks
force-pushed
the
sl/add-linting
branch
from
84dd827 to
8ed13f6
Compare
stuartleeks
force-pushed
the
sl/add-linting
branch
2 times, most recently
from
b64f120 to
466cdee
Compare
Azadehkhojandi
approved these changes
Nov 26, 2019
Contributor
Azadehkhojandi
left a comment
Azadehkhojandi
left a comment
There was a problem hiding this comment.
Looks good to me, thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #111