Skip to content
This repository was archived by the owner on Jan 28, 2022. It is now read-only.

Commit abb9853

Browse files
committed
re-add vet as per PR review comments
1 parent 6542be4 commit abb9853

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

Makefile

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ CRD_OPTIONS ?= "crd:trivialVersions=true"
77
all: manager
88

99
# Run tests
10-
test: generate fmt lint manifests
10+
test: generate fmt lint vet manifests
1111
rm -rf cover.* cover
1212
mkdir -p cover
1313

@@ -20,7 +20,7 @@ test: generate fmt lint manifests
2020
rm -f cover.out cover.out.tmp cover.json
2121

2222
# Run tests with existing cluster
23-
test-existing: generate fmt lint manifests
23+
test-existing: generate fmt lint vet manifests
2424
rm -rf cover.* cover
2525
mkdir -p cover
2626

@@ -33,11 +33,11 @@ test-existing: generate fmt lint manifests
3333
rm -f cover.out cover.out.tmp cover.json
3434

3535
# Build manager binary
36-
manager: generate fmt lint
36+
manager: generate fmt lint vet
3737
go build -o bin/manager main.go
3838

3939
# Run against the configured Kubernetes cluster in ~/.kube/config
40-
run: generate fmt lint
40+
run: generate fmt lint vet
4141
go run ./main.go
4242

4343
# Install CRDs into a cluster
@@ -80,6 +80,10 @@ manifests: controller-gen
8080
fmt:
8181
find . -name '*.go' | grep -v vendor | xargs gofmt -s -w
8282

83+
# Run go vet against code
84+
vet:
85+
go vet ./...
86+
8387
# Run linting
8488
lint:
8589
GO111MODULE=on golangci-lint run

0 commit comments

Comments
 (0)