Fixed the maxConcurrency parameter summary#3
Merged
Conversation
|
@christopheranderson Are there plans to hook up a CI build to this repo? |
|
Yep. @ausfeldt is on it. We'll be set up to run CI and accept PRs/etc. We have a public VSTS account set up so test results/etc. can be visible. |
christopheranderson
added
bug
ausfeldt
added a commit
that referenced
this pull request
Mar 2, 2019
Fixed the maxConcurrency parameter summary
4 tasks
1 task
NaluTripician
added a commit
that referenced
this pull request
May 8, 2026
…back Addresses review comments on PR #5829: - #3 Renames shadowing parameters in UpdatePartitionLevelFailoverConfigWithAccountRefresh (isEnabled -> latestIsEnabled, disableCrossRegionalHedging -> latestDisableCrossRegionalHedging) so a future edit dropping a 'this.' prefix cannot silently change semantics. - #6 Adds early-return guard when neither PPAF enablement nor the hedging flag changed, protecting future direct callers from spurious AvailabilityStrategy mutation. - #5 Introduces hedgingStrategyLock and serializes the (flag, stash, ConnectionPolicy.AvailabilityStrategy) mutation sequence in UpdatePartitionLevelFailoverConfigWithAccountRefresh and ApplyHedgingStrategyForCurrentState, so concurrent invocations cannot interleave stash/clear/restore steps. - #11 Emits a TraceWarning when ApplyHedgingStrategyForCurrentState would silently drop a non-default AvailabilityStrategy because a previously-stashed customer strategy is still held. - #8 Replaces reflection-based field access in GatewayHedgingOverrideTests with internal test-only properties (DisableCrossRegionalHedgingForTests, CustomerConfiguredAvailabilityStrategyForTests), so renames are caught at compile time. - #2 / #12 Moves the init-time flag capture and customer-strategy stash from GetInitializationTaskAsync into InitializeGatewayConfigurationReaderAsync, before the GEM background-refresh loop is started and before the change-event handler is subscribed. This eliminates the theoretical race where a refresh-driven event could be overwritten by a subsequent init-time field assignment, and removes the inconsistent null-check style. - #10 Removes unrelated .coding-harness/ entry from .gitignore. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description for the
maxConcurrencyparameter was talking about thePartitionKey, probably leftovers from a previous method signature.This PR fixes that.