Skip to content

CancellationToken: Fixes User Cancellation Token by Propagating Through Initialization Request Call Stack#3284

Closed
imanvt wants to merge 8 commits into
masterfrom
users/imanvt/3279-user-cancellationtoken-propagation
Closed

CancellationToken: Fixes User Cancellation Token by Propagating Through Initialization Request Call Stack#3284
imanvt wants to merge 8 commits into
masterfrom
users/imanvt/3279-user-cancellationtoken-propagation

Conversation

@imanvt
Copy link
Copy Markdown
Contributor

@imanvt imanvt commented Jun 21, 2022

Pull Request Template

Description

During client initialization requests, the user passed cancellation token is not passed all the way through. This PR closes many of those gaps.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

closes #3279

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@imanvt imanvt changed the title CancellationToken: Propagate User Token Through Initialization Request Call Stack CancellationToken: Fixes User Cancellation Token by Propagating Through Initialization Request Call Stack Jun 21, 2022
@imanvt imanvt marked this pull request as ready for review June 21, 2022 22:35
Comment thread Microsoft.Azure.Cosmos/src/Routing/PartitionKeyRangeCache.cs Outdated
@imanvt imanvt closed this Jun 27, 2022
@imanvt imanvt deleted the users/imanvt/3279-user-cancellationtoken-propagation branch August 17, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CancellationToken: User provided CT not flowing for initialization related requests

3 participants