Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: fix: pass ai metadata to telemetry during cni image build (#3095) #3132

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Nov 8, 2024

Reason for Change:

Backports #3095
Updates Linux dockerfile since in v1.5 the dockerfile is split per OS

Issue Fixed:

Requirements:

Notes:

QxBytes and others added 2 commits November 8, 2024 10:49
* fix log on ai telemetry handle create error

* fix failure to pass cni ai id at build time for cni images

* address feedback

* move ai id to hardcoded variable

* update unit test

* Revert "move ai id to hardcoded variable"

This reverts commit 666c2b0.

* fix typo
@QxBytes QxBytes force-pushed the alew/backport-log-telemetry-error branch from 88a1c56 to f25f29c Compare November 8, 2024 18:49
@QxBytes QxBytes added cni Related to CNI. fix Fixes something. ci Infra or tooling. telemetry logging release/1.5 Change affects v1.5 release train labels Nov 8, 2024
@QxBytes QxBytes self-assigned this Nov 8, 2024
@QxBytes QxBytes marked this pull request as ready for review November 8, 2024 18:53
@QxBytes QxBytes requested review from a team as code owners November 8, 2024 18:53
@rbtr
Copy link
Contributor

rbtr commented Nov 11, 2024

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2024
@QxBytes QxBytes added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into release/v1.5 with commit 46afd5e Nov 14, 2024
99 of 100 checks passed
@paulyufan2 paulyufan2 deleted the alew/backport-log-telemetry-error branch November 14, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. cni Related to CNI. fix Fixes something. logging release/1.5 Change affects v1.5 release train telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants