-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: fix: pass ai metadata to telemetry during cni image build (#3095) #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix log on ai telemetry handle create error * fix failure to pass cni ai id at build time for cni images * address feedback * move ai id to hardcoded variable * update unit test * Revert "move ai id to hardcoded variable" This reverts commit 666c2b0. * fix typo
QxBytes
force-pushed
the
alew/backport-log-telemetry-error
branch
from
November 8, 2024 18:49
88a1c56
to
f25f29c
Compare
QxBytes
added
cni
Related to CNI.
fix
Fixes something.
ci
Infra or tooling.
telemetry
logging
release/1.5
Change affects v1.5 release train
labels
Nov 8, 2024
rbtr
approved these changes
Nov 11, 2024
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Backports #3095
Updates Linux dockerfile since in v1.5 the dockerfile is split per OS
Issue Fixed:
Requirements:
Notes: