fix: pass ai metadata to telemetry during cni image build #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QxBytes
added
the
needs-backport
timraymond
reviewed
Oct 31, 2024
This reverts commit 666c2b0.
timraymond
reviewed
Nov 4, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rbtr
approved these changes
Nov 4, 2024
timraymond
approved these changes
Nov 4, 2024
QxBytes
added a commit
that referenced
this pull request
Nov 7, 2024
* fix log on ai telemetry handle create error * fix failure to pass cni ai id at build time for cni images * address feedback * move ai id to hardcoded variable * update unit test * Revert "move ai id to hardcoded variable" This reverts commit 666c2b0. * fix typo
4 tasks
QxBytes
added a commit
that referenced
this pull request
Nov 8, 2024
* fix log on ai telemetry handle create error * fix failure to pass cni ai id at build time for cni images * address feedback * move ai id to hardcoded variable * update unit test * Revert "move ai id to hardcoded variable" This reverts commit 666c2b0. * fix typo
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…3095) (#3132) * fix: pass ai metadata to telemetry during cni image build (#3095) * fix log on ai telemetry handle create error * fix failure to pass cni ai id at build time for cni images * address feedback * move ai id to hardcoded variable * update unit test * Revert "move ai id to hardcoded variable" This reverts commit 666c2b0. * fix typo * add cni ai info to cni image args and linux dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the cni dockerfile to take in arguments for the ai metadata, similar to the cns dockerfile.
Reason for Change:
The ai instrumentation key previously was not passed when building the azure vnet telemetry binary when making a cni image. The instrumentation key was passed when making the binary with the make file command, however.
Also fixed an error message not logging which hid the above error.
Issue Fixed:
See above
Requirements:
Notes:
Tested on podsubnet cluster. No logs were found to be uploaded, and noticed telemetry logs showed an ai handle creation error. However, after applying the cni image with the fix using the cni installer, we started to receive logs. The telemetry logs also no longer produced the error message.