Skip to content

feat) add support for "S1" SKU #7994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjprescott merged 2 commits into from Dec 7, 2018
Merged

feat) add support for "S1" SKU #7994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce91ea
feat) add support for "S1" SKU
Dec 6, 2018
a7ed938
chore) correct build/ci-cd errors
Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/command_modules/azure-cli-maps/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
Release History
===============

0.3.3
+++++
* Add support for the S1 SKU: `maps account create | update`: now supports `S1` as a valid value for the `--sku | -s` parameter.

0.3.2
+++++
* Minor fixes
Expand Down
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-maps/azure/cli/command_modules/maps/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def load_arguments(self, _):
c.argument('sku_name',
options_list=['--sku', '-s'],
help='The name of the SKU.',
arg_type=get_enum_type(['S0']))
arg_type=get_enum_type(['S0', 'S1']))
Copy link
Member

@tjprescott tjprescott Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an enum in your SDK for this parameter? If so, you can simply pass the enum class and not have to manually update the CLI each time.

Copy link
Contributor Author

@SudhindraKovalam SudhindraKovalam Dec 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now, we dont, but thats a good idea, Will change this

c.argument('tags',
arg_type=tags_type)

Expand Down
Loading