feat) add support for "S1" SKU #7994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
reviewed
Dec 6, 2018
| options_list=['--sku', '-s'], | ||
| help='The name of the SKU.', | ||
| arg_type=get_enum_type(['S0'])) | ||
| arg_type=get_enum_type(['S0', 'S1'])) |
Member
There was a problem hiding this comment.
Is there an enum in your SDK for this parameter? If so, you can simply pass the enum class and not have to manually update the CLI each time.
Contributor
Author
There was a problem hiding this comment.
for now, we dont, but thats a good idea, Will change this
tjprescott
approved these changes
Dec 6, 2018
Member
|
@SudhindraKovalam please get the CI green. |
Contributor
Author
|
@tjprescott got the CI to green , thanks for all your help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat) Add support for the
S1SKU parameterThis checklist is used to make sure that common guidelines for a pull request are followed.
[x ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
[x ] I adhere to the Command Guidelines.