[DO NOT MERGE] [ACR] Switch from logger.warning to print for ACR build and tasks #7982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added MacOS example for generating SAS token with expiration time. The call to the date function `date -d` works on Linux, but not on MacOS. I provided MacOS sample.
Updated help text and test location for low priority vmss
…ion (#7863) * authentication-type can be set to all to permit both ssh key and password authentication * Added tests and updated authentication type validation error. * Added history entry, bumped version. Checked out file recording from dev branch. * Addressed PEP8 issues. * Updated test_vm_defaults auth tests. * Updated other profile's unittests. * Now infers authentication_type, other updates. Do not need to explicitly pass all. * Updated help text. Fix conflict by checking out ephemeral os disk recording from dev branch. * Style changes.
* Properly handle parsing of ids from -o tsv on windows. * Removed unused import.
…se. (#7869) * changed api-version in recordings and set to new ver of sdk * version bump and history * fix immutability test * re-record all * fixed recordings fix recording * bumped version after release
* reenable extension checking in CI minor edit to get travis to run edit * minor edit
* support key-id description * linter error fixes * consolidate * use official sdk * update history
…7941) * BotService: fix tests, mprove test robustness and update recordings * BotService; fixing tests * BotService: Update recordings
* core: fix a breaking in kv when run under service principal * test: add test coverage for regression from auth
* [AKS] Remove "(PREVIEW)" from AAD arguments * Bump module version and update HISTORY.rst
* Az bot: fix bug when publishing Node.js bots, fix minor bugs * Az bot: rerecord BotTests * Az bot: fix static check error
* Updated location help text. * Update parameters.py
* EventHubs help fixes #Fixes 7937. Fixes #7938. * Update _help.py
* Remove mock dependency. * Fix linter issues.
* upstream/dev: (41 commits) Call SubResource correctly in list comprehension (#7974) Fixes for VPN Client Generate (#7962) EventHubs help fixes (#7961) [core] Updated location help text (#7951) Bug fixes for azure-cli-botservice (#7956) [AKS] Remove "(PREVIEW)" from AAD arguments (#7960) test: add test coverage for regression from auth (#7949) Disable version check from CI. (#7958) core: fix a breaking in kv when run under service principal (#7946) webapp: Adding support for az webapp up (#7930) BotService: fix tests, improve test robustness and update recordings (#7941) graph: support custom key identifier (#7913) [image] create. Add --os-disk-caching parameter. (#7919) Minor updates to core/generate_ssh_keys and batchai/_generate_ssh_keys (#7895) Close #7528. (#7920) BotService: Bugfixing, code refactoring, reorganization and UX revamping (#7924) [CI] reenable extension checking in CI (#7933) resource: fix live test failure of policyset (#7922) core: fix the error on matching SP creds (#7923) core: support cross tenant resource provisioning for multi-tenant service principal (#7916) ...
* dev: (41 commits) Call SubResource correctly in list comprehension (#7974) Fixes for VPN Client Generate (#7962) EventHubs help fixes (#7961) [core] Updated location help text (#7951) Bug fixes for azure-cli-botservice (#7956) [AKS] Remove "(PREVIEW)" from AAD arguments (#7960) test: add test coverage for regression from auth (#7949) Disable version check from CI. (#7958) core: fix a breaking in kv when run under service principal (#7946) webapp: Adding support for az webapp up (#7930) BotService: fix tests, improve test robustness and update recordings (#7941) graph: support custom key identifier (#7913) [image] create. Add --os-disk-caching parameter. (#7919) Minor updates to core/generate_ssh_keys and batchai/_generate_ssh_keys (#7895) Close #7528. (#7920) BotService: Bugfixing, code refactoring, reorganization and UX revamping (#7924) [CI] reenable extension checking in CI (#7933) resource: fix live test failure of policyset (#7922) core: fix the error on matching SP creds (#7923) core: support cross tenant resource provisioning for multi-tenant service principal (#7916) ...
Contributor
Author
|
@tjprescott / @williexu / @yugangw-msft could you PTAL at this and #7980 |
* dev: bugfix: multicontainer honors slot (#7952) [Consumption]: Fixed transformer bugs for budget API to show notifications. (#7971) [Core] revert break in core (#8012) feat) add support for "S1" SKU (#7994) [Storage] add example for prefix and rem duplicate entry (#8005) [ACR] Condense the table format for task list (#7980) Fix #7959. (#7993) Re-record the world. (#7968)
tjprescott
requested review from
yugangw-msft
and removed request for
tjprescott
ehotinger
changed the title
Contributor
Author
|
Closing for now after internal discussion. May reopen in the future with additional changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from
logger.warningtoprinton ACR build and tasks commands. These commands are frequently used by CI/CD processes andlogger.warningwill output to stderr. In certain cases the CI/CD pipelines will fail if anything appears on stderr that isn't a real error. Since the default trace level doesn't work forlogger.info, we're switching these toprintso that they're displayed on stdout.Fixes Azure/acr#162
/cc @djyou @northtyphoon @ankurkhemani @jaysterp
This is as mentioned in our previous emails @tjprescott + @yugangw-msft
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.