-
Notifications
You must be signed in to change notification settings - Fork 3.3k
rbac: list & delete assignment; role definition create, list and delete #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f893a25 to
9f79f1a
Compare
|
26c9d29 to
ff2d08d
Compare
107b4a4 to
9142af4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
show_role_create_template [](start = 4, length = 25)
Is there a reason this isn't just part of the "examples" help text for the create role command? It seems odd to have a command that just outputs what is essentially help text (except the taskhelp module but that's totally different)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After our discussion I understand the rationale. Once you've changed the create_role command to be multiple parameters, I'm not sure this would be necessary. Even if we preserve the ability to use a JSON template as the input, they could just get the template from the examples portion of the help file. I'd ask others what they think.
In reply to: 73603847 [](ancestors = 73603847)
|
@tjprescott , on a second thought, I feel it better to just get rid of the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roles match [](start = 33, length = 11)
This should be 'more than one role matches' like it was before this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Forgive me, i just could not get this grammar right.
|
|
…te (Azure#602) * list assignment * role: create and delete
* Fixes Azure#591. * Update index for ER cross connection * Fix linter violations.
| :param include_groups: include extra assignments to the groups of which the user is a | ||
| member(transitively). Supported only for a user principal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include_groups should be declared in _params.py, not here.
Notes by comparing with node cli
create,list,deleteconsistent. By using the same filter, those 3 command will work on the same assignment. Node cli doesn't have this behavior, which is confusingscope, they just need to use either resource group, or resource id--all,--include-inheritedfor people to opt-in to see extra assignments if they likedelete, i have not made up mind of whether to expose--allto delete all assignments. Feel it somehow risky operations. But feel free to comment./CC:@derekbekoe, @BurtBiel, @tjprescott , @JasonRShaver