Skip to content

Remove warning log messages for Long Running Operations #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yugangw-msft merged 2 commits into from
Aug 2, 2016
Merged

Remove warning log messages for Long Running Operations #591

yugangw-msft merged 2 commits into from
Aug 2, 2016

Conversation

@derekbekoe
Copy link
Member

@derekbekoe derekbekoe commented Aug 1, 2016

No description provided.

@azurecla
Copy link

azurecla commented Aug 1, 2016

Hi @derekbekoe, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@derekbekoe derekbekoe mentioned this pull request Aug 1, 2016
Closed
yugangw-msft
yugangw-msft reviewed Aug 1, 2016
View reviewed changes
src/azure/cli/commands/__init__.py Outdated
Copy link
Contributor

@yugangw-msft yugangw-msft Aug 1, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this change personally, but for the people get used to interactive flow, is it possible we can still output the starting message, but just don't prefix with "warning:"?

Copy link
Member Author

@derekbekoe derekbekoe Aug 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'WARNING:' is not displayed in interactive mode (if there's a TTY available).
But log message are prefixed with the log level if there is no TTY (e.g. redirecting the output to file) as was the case in #572.

@tjprescott
Copy link
Member

tjprescott commented Aug 1, 2016

:shipit:

@yugangw-msft yugangw-msft merged commit 130b05d into Azure:master Aug 2, 2016
@derekbekoe derekbekoe deleted the lro-no-log branch August 2, 2016 16:21
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
@tjprescott
Fixes Azure#591. (Azure#601)
5d6cbcd
00Kai0 pushed a commit to 00Kai0/azure-cli that referenced this pull request Apr 7, 2021
@tjprescott
Update index for ER Cross Connection (Azure#602)
1a27835 
* Fixes Azure#591.

* Update index for ER cross connection

* Fix linter violations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yugangw-msft yugangw-msft

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@derekbekoe @azurecla @tjprescott @yugangw-msft @haroldrandom