-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Cloud] Update active_directory_graph_resource_id endpoint of AZURE_US_GOV_CLOUD
#31849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Active Directory Graph resource endpoint for Azure US Government Cloud from a legacy Windows endpoint to the current Microsoft Azure US endpoint. This change aligns the AZURE_US_GOV_CLOUD configuration with the proper government cloud endpoint.
- Updates
active_directory_graph_resource_idfromhttps://graph.windows.net/tohttps://graph.microsoftazure.us/
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
The Should change it to after CI passes. |
active_directory_graph_resource_id endpoint of AZURE_US_GOV_CLOUD to https://graph.microsoftazure.us/active_directory_graph_resource_id endpoint of AZURE_US_GOV_CLOUD
| active_directory='https://login.microsoftonline.us', | ||
| active_directory_resource_id='https://management.core.usgovcloudapi.net/', | ||
| active_directory_graph_resource_id='https://graph.windows.net/', | ||
| active_directory_graph_resource_id='https://graph.microsoftazure.us/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also found https://graph.microsoftazure.us/ at https://learn.microsoft.com/en-us/graph/migrate-azure-ad-graph-request-differences#basic-requests
Description
#1098 used
https://graph.windows.net/asactive_directory_graph_resource_idforAZURE_US_GOV_CLOUDand hasn't change since then.According to an internal TSG and https://learn.microsoft.com/en-us/graph/migrate-azure-ad-graph-request-differences,
AZURE_US_GOV_CLOUDnow has its dedicated AD Graph endpointhttps://graph.microsoftazure.us/.az ad/role: Azure AD Graph API to Microsoft Graph API migration #22432, https://learn.microsoft.com/en-us/cli/azure/microsoft-graph-migration?view=azure-cli-latestazure-graphrbacSDK #29838So the
active_directory_graph_resource_idendpoint ofAZURE_US_GOV_CLOUDshould no longer be used, but this PR updates it tohttps://graph.microsoftazure.us/anyway.Corresponding Azure PowerShell PR: Azure/azure-powershell#28247
History Notes
[Cloud] Change
active_directory_graph_resource_idendpoint ofAZURE_US_GOV_CLOUDtohttps://graph.microsoftazure.us/