Skip to content

{Core} Update Next Breaking Change Release Version Number #30288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReaNAiveD merged 1 commit into from
Nov 12, 2024
Merged

{Core} Update Next Breaking Change Release Version Number #30288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/breaking_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

logger = get_logger()

NEXT_BREAKING_CHANGE_RELEASE = '2.67.0'
NEXT_BREAKING_CHANGE_RELEASE = '2.73.0'
Copy link
Contributor

@bebound bebound Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use 2.74 in this PR: https://github.com/Azure/azure-cli/pull/30091/files#diff-4e144054c791bf4f8c57a14e455f64cd81b89021be6075fc60f12d75002ac02bR42

Please double confirm the version number.

Copy link
Member Author

@ReaNAiveD ReaNAiveD Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reached out to Yong regarding the next breaking change version number and received 2.73.0 as the response. I'm flexible with either 2.73.0 or 2.74.0, as I plan to update to the confirmed version as soon as it's finalized.

Copy link
Contributor

@bebound bebound Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find 2.73.0 in https://learn.microsoft.com/en-us/cli/azure/azure-cli-support-lifecycle too.
Hmm, #30091 might be wrong.

Copy link
Contributor

@bebound bebound Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.54.0 is 2023 ignite version, 2.61.0 is 2024 build version. They differ by 7 versions, weird.

Copy link
Member

@jiasli jiasli Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got 2.74 from @dcaro: #30091 (comment).

Copy link
Member Author

@ReaNAiveD ReaNAiveD Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's acceptable to merge this PR for now. We can create another PR once we have the finalized version.

DEFAULT_BREAKING_CHANGE_TAG = '[Breaking Change]'


Expand Down