-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{Core} Update Next Breaking Change Release Version Number #30288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @ReaNAiveD, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
| logger = get_logger() | ||
|
|
||
| NEXT_BREAKING_CHANGE_RELEASE = '2.67.0' | ||
| NEXT_BREAKING_CHANGE_RELEASE = '2.73.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use 2.74 in this PR: https://github.com/Azure/azure-cli/pull/30091/files#diff-4e144054c791bf4f8c57a14e455f64cd81b89021be6075fc60f12d75002ac02bR42
Please double confirm the version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reached out to Yong regarding the next breaking change version number and received 2.73.0 as the response. I'm flexible with either 2.73.0 or 2.74.0, as I plan to update to the confirmed version as soon as it's finalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find 2.73.0 in https://learn.microsoft.com/en-us/cli/azure/azure-cli-support-lifecycle too.
Hmm, #30091 might be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.54.0 is 2023 ignite version, 2.61.0 is 2024 build version. They differ by 7 versions, weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got 2.74 from @dcaro: #30091 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's acceptable to merge this PR for now. We can create another PR once we have the finalized version.
Related command
Description
Update the breaking change release version.
It is recommended to update the version during the breaking change window. This will help avoid any issues with pre-announcements that indicate changes will occur in the current version after relase.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.