{ACS} az aks approuting: Creating commands for approuting enable|disable|keyvault as well as dns zone add|remove|list
#28463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfoley13
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @bfoley13, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks approuting | sub group aks approuting added |
||
| aks create | cmd aks create added parameter enable_app_routing |
Collaborator
|
ACS |
microsoft-github-policy-service
bot
requested review from
FumingZhang,
evelyn-ys and
yonzhan
FumingZhang
reviewed
Feb 27, 2024
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please fix failed CI checks.
This PR moves the implementation in aks-preview to official azure-cli
src/azure-cli/azure/cli/command_modules/acs/tests/latest/recordings/test_aks_abort.yaml
Outdated
Show resolved
Hide resolved
...li/command_modules/acs/tests/latest/recordings/test_aks_api_server_authorized_ip_ranges.yaml
Outdated
Show resolved
Hide resolved
...es/acs/tests/latest/recordings/test_aks_approuting_update_with_monitoring_addon_enabled.yaml
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_create_with_app_routing_enabled
- test_aks_approuting_enable_disable
- test_aks_approuting_enable_with_keyvault_secrets_provider_addon_and_keyvault_id
- test_aks_approuting_update
- test_aks_approuting_update_with_monitoring_addon_enabled
- test_aks_approuting_zone_add_delete_list
- test_aks_approuting_zone_update
bfoley13
requested review from
calvinhzy,
jiasli,
kairu-ms,
necusjz and
wangzelin007
as code owners
bfoley13
force-pushed
the
dev
branch
2 times, most recently
from
eee0452 to
d485908
Compare
bfoley13
changed the title
az aks approuting: updating commands for approuting enable|disable|keyvault as well as dns zone add|remove|list
bfoley13
changed the title
az aks approuting: updating commands for approuting enable|disable|keyvault as well as dns zone add|remove|listaz aks approuting: Creating commands for approuting enable|disable|keyvault as well as dns zone add|remove|list
Member
|
Full test CI failed due to the recording of test_aks_approuting_enable_with_keyvault_secrets_provider_addon_and_keyvault_id is not valid, reran the test, may find the recording file from pipeline artifact and commit the new one. |
Member
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28463 in repo Azure/azure-cli |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Feb 29, 2024
FumingZhang
reviewed
Mar 1, 2024
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please also resolve merge conflict
* Adding App Routing Support to acs * small updates * latest updates * KV changes * Moving kv handling to update decorator * update live tests
Contributor
|
Since it seems to have mutiply changes in this PR, it is better to split the changelog into several small items and add them in the History Notes part in the above description. |
yanzhudd
approved these changes
Mar 8, 2024
yanzhudd
changed the title
az aks approuting: Creating commands for approuting enable|disable|keyvault as well as dns zone add|remove|listaz aks approuting: Creating commands for approuting enable|disable|keyvault as well as dns zone add|remove|list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks
Description
The app routing add-on has migrated to the stable api for AKS. This PR adds the same features within the preview cli ti the az aks cli.
This adds a flag to cluster create for enabling the addon:
az aks create ... --enable-app-routing
This also adds the approuting sub command to az aks:
az aks approuting [enable|disable|update]
And the zone sub command to the approuting command:
az aks approuting zone [add|delete|update|list]
Testing Guide
History Notes
[ACS]
az aks create: Add flag--enable-app-routingto enable app routing[ACS]
az aks approuting: Add command group to handle enable|disable|update of the approuting addon[ACS]
az aks approuting zone: Add command group to handle add|delete|update|list actions of dns zone resources associated to the approuting addonThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.