-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AKS] Added support for Private DNS Zone Contributor role assignment in app routing #7284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] Added support for Private DNS Zone Contributor role assignment in app routing #7284
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @bosesuneha, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Closes #7249 |
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test to validate the change.
- test_aks_create_web_application_routing_with_private_dns_zone
- test_aks_create_and_update_web_application_routing_dns_zone
…com/bosesuneha/azure-cli-extensions into support-private-dns-zone-in-war-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requeued live test, test passed!
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks approuting zone add --ids {private_dns_zone} --attach-zones -n -g
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.