Skip to content

Conversation

@bosesuneha
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks approuting zone add --ids {private_dns_zone} --attach-zones -n -g

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 12, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @bosesuneha,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 12, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@bosesuneha bosesuneha changed the title Added support for Private DNS Zone Contributor role assignment in app routing [AKS] Added support for Private DNS Zone Contributor role assignment in app routing Feb 12, 2024
@sabbour
Copy link

sabbour commented Feb 13, 2024

Closes #7249

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_create_web_application_routing_with_private_dns_zone
  • test_aks_create_and_update_web_application_routing_dns_zone

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requeued live test, test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants