[AKS] support premium tier and add supportPlan#26795
Merged
zhoxing-ms merged 37 commits intoAzure:devfrom Jul 7, 2023
Merged
Conversation
haitch
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| is_break | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter k8s_support_plan |
||
| aks create | cmd aks create update parameter tier: updated property choices from ['free', 'standard'] to ['free', 'premium', 'standard'] |
||
| aks update | cmd aks update added parameter k8s_support_plan |
||
| aks update | cmd aks update update parameter tier: updated property choices from ['free', 'standard'] to ['free', 'premium', 'standard'] |
FumingZhang
reviewed
Jul 4, 2023
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
FumingZhang
reviewed
Jul 4, 2023
FumingZhang
reviewed
Jul 4, 2023
FumingZhang
reviewed
Jul 4, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Maybe add a new test for the new feature?
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Contributor
Author
|
@FumingZhang need your help on the last test test_aks_create_and_update_with_http_proxy_config, it never works for me. |
Member
|
/azp run |
|
No commit pushedDate could be found for PR 26795 in repo Azure/azure-cli |
Member
|
The recording from artifact should works fine for test_aks_create_and_update_with_http_proxy_config |
Member
|
And the other one works fine for test_aks_nodepool_snapshot |
Contributor
Author
I will add that later via separate PR. |
Contributor
|
Could you please add some test cases for this PR changes? |
Contributor
Could you describe the |
Contributor
Author
this would be blocked on server side pending some backend feature complete, we will add test once the server side feature finish and unblock create of LTS cluster. |
zhoxing-ms
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks create
az aks update
Description
AKS start to offering LongTermSupport (LTS) for Kubernetes via Premium tier from 1.27, this CLI work is to complete the client experience.
Testing Guide
command to create new aks cluster with LTS
az aks create -g haitao -n ltsncus --kubernetes-support-plan AKSLongTermSupport -k 1.27.1 --tier premium -l southcentraluscommand to onboard LTS feature for existing cluster
az aks update -g haitao -n ltsncus --kubernetes-support-plan AKSLongTermSupport --tier premiumcommand to off-board LTS feature.
az aks update -g haitao -n ltsncus --kubernetes-support-plan KubernetesOfficialHistory Notes
[AKS]
az aks create: Add new parameter--k8s-support-planto support LTS onboarding, also add new tier enumpremium[AKS]
az aks update: Support to enable/disable LTS via new parameter--k8s-support-planThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.