[AKS] support premium tier and add supportPlan#6753
Closed
m-chau wants to merge 15 commits intoAzure:mainfrom
Closed
[AKS] support premium tier and add supportPlan#6753m-chau wants to merge 15 commits intoAzure:mainfrom
m-chau wants to merge 15 commits intoAzure:mainfrom
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter k8s_support_plan |
||
| aks create | cmd aks create update parameter tier: updated property choices from ['free', 'standard'] to ['free', 'premium', 'standard'] |
||
| aks update | cmd aks update added parameter k8s_support_plan |
||
| aks update | cmd aks update update parameter tier: updated property choices from ['free', 'standard'] to ['free', 'premium', 'standard'] |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
Collaborator
|
AKS |
Contributor
Author
|
Related CLI command PR: Azure/azure-cli#26795 |
FumingZhang
reviewed
Sep 13, 2023
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please add at least one live test case (see cases in test_aks_commands.py) for the newly added option.
FumingZhang
reviewed
Sep 14, 2023
| 'aks delete -g {resource_group} -n {name} --yes --no-wait', checks=[self.is_empty()]) | ||
|
|
||
| @AllowLargeResponse() | ||
| @AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2') |
yanzhudd
reviewed
Sep 20, 2023
Contributor
|
Please fix the failed CI task. |
Contributor
Author
@yanzhudd They are fixed. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create
az aks update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired) ranazdev linterinsteadpython scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.