{AKS} az aks get-versions: get-versions using newer backend api
#26702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangwei36
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
ghost
assigned
ghost
requested review from
Contributor
Author
|
@FumingZhang, I am helping @haitch to submit this PR. Let me know if there is any other issues. |
xiangwei36
changed the title
FumingZhang
reviewed
Jun 19, 2023
| """Return the previous and current Kubernetes minor release versions, such as ("1.11.6", "1.12.4").""" | ||
| versions = self.cmd( | ||
| "az aks get-versions -l westus2 --query 'orchestrators[].orchestratorVersion'").get_output_in_json() | ||
| "az aks get-versions -l westus2 --query 'values[*].patchVersions.keys(@)[]'").get_output_in_json() |
Member
There was a problem hiding this comment.
Is this change necessary? To me, the recording file is not changed, so I guess without the change, the test could pass.
Contributor
Author
There was a problem hiding this comment.
The unit test that has _get_versions is test_aks_create_service_no_wait which is live_only.
Contributor
There was a problem hiding this comment.
@FumingZhang , I think I just did a search of "get-versions", and update here.
And, I am expecting this need to be updated as well, unless the hybrid test is something different.
Member
There was a problem hiding this comment.
OK, as the recording file for the hybrid version is not updated, I thought we may keep the test case unchanged. But CI has passed, shouldn't block the change.
FumingZhang
approved these changes
Jun 20, 2023
zhoxing-ms
reviewed
Jun 20, 2023
| results = cf_managed_clusters(cli_ctx).list_kubernetes_versions(location).as_dict() | ||
| # Flatten all the "orchestrator_version" fields into one array | ||
| return search('orchestrators[*].orchestrator_version', results) | ||
| return search("values[*].patchVersions.keys(@)[]", results) |
Contributor
There was a problem hiding this comment.
May I ask if this modification will change the output logic and cause a breaking change to customers?
Contributor
Author
There was a problem hiding this comment.
This is not a breaking change. Customers will not experience any interruptions.
zhoxing-ms
approved these changes
Jun 21, 2023
zhoxing-ms
changed the title
az aks get-versions: get-versions using newer backend api
3 tasks
amatukmolina
pushed a commit
to amatukmolina/azure-cli
that referenced
this pull request
Jun 29, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks get-versions
Description
AKS offer a new simpler api for listKubernetesVersions, to replace legacy api ListOrchestratorProfile, which was designed to support docker swam and apache mesosphere.
Testing Guide
compare out put between old and new az aks get-versions, data should remain same, but json/table output have minor changes.
History Notes
[aks] BREAKING CHANGE: Both json payload and table format changed for
az aks get-versionsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.