Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Update recording files as the inherited command az aks get-versions (from azure-cli) changed its backend API by PR #26702.
  • Fix role assignment check failure.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@ghost ghost requested a review from zhoxing-ms June 25, 2023 06:18
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 25, 2023

AKS

@ghost ghost requested a review from yanzhudd June 25, 2023 06:18
@ghost ghost assigned zhoxing-ms Jun 25, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 25, 2023
@ghost ghost requested a review from yonzhan June 25, 2023 06:18
@ghost ghost added the AKS label Jun 25, 2023
@zhoxing-ms zhoxing-ms merged commit 8fe4ddb into Azure:main Jun 25, 2023
@FumingZhang FumingZhang deleted the fuming/aks-get-versions-0625 branch June 28, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants