Skip to content

{CI} azdev style check ignore aaz folder #26492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangzelin007 merged 4 commits into from
May 25, 2023
Merged

{CI} azdev style check ignore aaz folder #26492

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06e7274
update
wangzelin007 May 19, 2023
5bad276
update
wangzelin007 May 19, 2023
95d3f41
Update __init__.py
wangzelin007 May 19, 2023
1faa04c
update
wangzelin007 May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .flake8
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ exclude =
*/grammar/
vendored_sdks
tests
aaz
2 changes: 1 addition & 1 deletion pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[MASTER]
ignore=tests,generated,vendored_sdks,privates
ignore=tests,generated,vendored_sdks,privates,aaz

@jiasli jiasli May 19, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this also make src/azure-cli-core/azure/cli/core/aaz unchecked?

@wangzelin007 wangzelin007 May 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just testing first to see if it can improve the test speed.
These parameters are more complicated than we think.

  • The ignore parameter represents Files or directories to be skipped. They should be base names, not paths.
  • The ignore-patterns parameter represents Files or directories matching the regular expression patterns are skipped.The regex matches against base names, not paths.
  • The ignore-paths parameter represents Files or directories matching the regular expressions patterns to the ignore-list, but I use the pylint 2.11.1 version test and it doesn't work.

@jiasli jiasli May 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be a good idea to rename aaz folders under azure/cli/command_modules (such as azure/cli/command_modules/network/aaz) to aaz_generated. It will make linter's configuration much easier.

@wangzelin007 wangzelin007 May 19, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much agree with your idea, we should rename all the directories generated by CodeGen to aaz_generated, not only main modules, but also extensions,
But I'm not too sure how much this affects CodeGen.
We can discuss this with @kairu-ms and I'll keep trying to see if there is a way to exclude directories.

ignore-patterns=test.*,azure_devops_build.*
reports=no

Expand Down