{CI} azdev style check ignore aaz folder #26492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
ghost
added
Collaborator
|
CI |
ghost
requested review from
jiasli
reviewed
May 19, 2023
pylintrc
Outdated
| @@ -1,5 +1,5 @@ | |||
| [MASTER] | |||
| ignore=tests,generated,vendored_sdks,privates | |||
| ignore=tests,generated,vendored_sdks,privates,aaz | |||
Member
There was a problem hiding this comment.
Will this also make src/azure-cli-core/azure/cli/core/aaz unchecked?
Member
Author
There was a problem hiding this comment.
I'm just testing first to see if it can improve the test speed.
These parameters are more complicated than we think.
- The ignore parameter represents
Files or directories to be skipped. They should be base names, not paths. - The ignore-patterns parameter represents
Files or directories matching the regular expression patterns are skipped.The regex matches against base names, not paths. - The ignore-paths parameter represents
Files or directories matching the regular expressions patterns to the ignore-list, but I use the pylint 2.11.1 version test and it doesn't work.
Member
There was a problem hiding this comment.
I think it may be a good idea to rename aaz folders under azure/cli/command_modules (such as azure/cli/command_modules/network/aaz) to aaz_generated. It will make linter's configuration much easier.
Member
Author
There was a problem hiding this comment.
I very much agree with your idea, we should rename all the directories generated by CodeGen to aaz_generated, not only main modules, but also extensions,
But I'm not too sure how much this affects CodeGen.
We can discuss this with @kairu-ms and I'll keep trying to see if there is a way to exclude directories.
wangzelin007
commented
May 19, 2023
| [MASTER] | ||
| ignore=tests,generated,vendored_sdks,privates | ||
| ignore-patterns=test.*,azure_devops_build.* | ||
| ignore-paths=.*/command_modules/.*/aaz |
Member
Author
There was a problem hiding this comment.
- The
ignoreparameter represents Files or directories to be skipped. They should be base names, not paths. - The
ignore-patternsparameter represents Files or directories matching the regular expression patterns are skipped. The regex matches against base names, not paths. - The
ignore-pathsparameter represents Files or directories matching the regular expressions patterns to the ignore-list.
We need include /core/aaz folder, so useignore-pathshere.
Reference code: https://github.com/pylint-dev/pylint/blob/main/examples/pylintrc#L48-L60
Member
|
@wangzelin007 Do we also want to apply this change to azure-cli-extensions repo? |
Member
Author
azure-cli-extensions repo do not have azdev style check, and we can simple add |
kairu-ms
approved these changes
May 19, 2023
jsntcy
approved these changes
May 19, 2023
necusjz
approved these changes
May 19, 2023
evelyn-ys
approved these changes
May 19, 2023
bebound
approved these changes
May 22, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
* update * update * Update __init__.py * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
azdev styleignore aaz folder, reduce the check time from 75min to 35min.It will still scan the core/aaz folder, as shown in the screenshot:
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.