{CI} Use serial test in azure-cli-core, iot, resource #26176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
azure-client-tools-bot-prd
bot
added this to the
May 2023 (2023-05-23) - For Build (Breaking change release) milestone
|
Hi @bebound, |
Collaborator
|
CI |
bebound
requested review from
calvinhzy,
jiasli,
kairu-ms and
wangzelin007
as code owners
wangzelin007
approved these changes
Apr 19, 2023
jiasli
reviewed
Apr 19, 2023
| elif exit_code != 0: | ||
| sys.exit(exit_code) | ||
|
|
||
| exit_code = subprocess.call(['{} --junit-xml /azure_cli_test_result/azure-cli-core.xml --pyargs azure.cli.core'.format(pytest_parallel_cmd)], shell=True) |
Member
There was a problem hiding this comment.
The concurrent writes mainly occur at
Since this sprint will end soon, in the next sprint I will see how I can mock set_cloud_subscription.
jiasli
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add those module to
serial_test_modulesto prevent failure in ARM64 Test because of high concurrency.core
It hardcode
cloud.configpath. See #26138iot
It does not use
random_config_dir, so the error occurs when write to same config file.azure-cli/src/azure-cli/azure/cli/command_modules/iot/__init__.py
Lines 14 to 29 in 7a087b1
resource
It consists of tests that install & uninstall same bicep binary file.
azure/cli/command_modules/resource/tests/latest/test_resource_bicep.pyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.