[ARM] Fix #26256: az bicep publish/restore/generate-params: Fix version checks without bicep installed
#26374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PramodValavala-MSFT
requested review from
jiasli,
jsntcy,
kairu-ms,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
May 2023 (2023-05-23) - For Build (Breaking change release) milestone
Collaborator
|
Bicep |
ghost
requested a review
from 
ghost
added
the
ARM
This was referenced May 8, 2023
bebound
reviewed
May 9, 2023
src/azure-cli/azure/cli/command_modules/resource/tests/latest/test_resource.py
Outdated
Show resolved
Hide resolved
PramodValavala-MSFT
changed the title
az bicep publish/restore/generate-params: Fix version checks without bicep installedaz bicep publish/restore/generate-params: Fix version checks without bicep installed
shenglol
previously approved these changes
May 10, 2023
Contributor
shenglol
left a comment
shenglol
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing this!
Contributor
|
@PramodValavala-MSFT Could you please resolve this conflict? |
Contributor
Author
Done 👍 |
zhoxing-ms
approved these changes
May 11, 2023
zhoxing-ms
changed the title
az bicep publish/restore/generate-params: Fix version checks without bicep installedaz bicep publish/restore/generate-params: Fix version checks without bicep installed
yash-nisar
pushed a commit
to yash-nisar/azure-cli
that referenced
this pull request
May 16, 2023
…x version checks without bicep installed (Azure#26374)
PramodValavala-MSFT
added
the
bug
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…x version checks without bicep installed (Azure#26374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Some commands require a specific version of
bicepto function and when trying to check the current version ofbicepinstalled, if thebicepCLI is not present, the commands fail.The workaround is to ensure the
bicepCLI is already installed. This PR ensures it is installed if it is already not before running the checks.Additionally, to improve test coverage, this extends the
random_config_dirproperty introduced in #25796 forLiveScenarioTests as well. @bebound FYIresolves #26256
Testing Guide
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.