Skip to content

[Feedback] Stop including error messages in the feedback body #25286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 2 commits into from
Feb 3, 2023
Merged

[Feedback] Stop including error messages in the feedback body #25286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77c99fc
feedback
jiasli Feb 2, 2023
84ccd2b
Update src/azure-cli/azure/cli/command_modules/feedback/custom.py
jiasli Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/azure-cli/azure/cli/command_modules/feedback/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@

**Errors:**
```
{errors_string}
Paste here the error message you have received. Make sure to remove all sensitive information,
such as user name, password, credential, subscription ID, etc.
```

## To Reproduce:
Expand Down Expand Up @@ -352,7 +353,6 @@ def _build_issue_info_tup(command_log_file=None):
format_dict["command_name"] = command_name

if command_log_file.command_data_dict:
errors_list = command_log_file.command_data_dict.get("errors", [])
executed_command = command_log_file.command_data_dict.get("command_args", "")
extension_name = command_log_file.command_data_dict.get("extension_name", "")
extension_version = command_log_file.command_data_dict.get("extension_version", "")
Expand All @@ -363,7 +363,6 @@ def _build_issue_info_tup(command_log_file=None):
is_ext = True
ext_name = extension_name

format_dict["errors_string"] = ''.join(errors_list)
format_dict["executed_command"] = "az " + executed_command if executed_command else executed_command
format_dict["command_name"] += extension_info

Expand Down
1 change: 0 additions & 1 deletion src/azure-cli/azure/cli/command_modules/feedback/tests/latest/test_feedback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ def _helper_test_build_issue_info(self):
for log_file, original_issue_body in items:
self.assertTrue(log_file.get_command_name_str() in original_issue_body)
self.assertTrue(log_file.command_data_dict["command_args"] in original_issue_body)
self.assertTrue(log_file.command_data_dict["errors"][0] in original_issue_body)

@staticmethod
def _ext_installed(ext):
Expand Down