Skip to content

[Packaging] Remove openssl1.1-compat and use openssl-dev in docker image #25119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bebound merged 2 commits into from
Feb 9, 2023
Merged

[Packaging] Remove openssl1.1-compat and use openssl-dev in docker image #25119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6092b5
Revert
bebound Jan 13, 2023
30820e8
Minor fix
bebound Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,8 @@ LABEL maintainer="Microsoft" \
# libintl and icu-libs - required by azure devops artifact (az extension add --name azure-devops)

# We don't use openssl (3.0) for now. We only install it so that users can use it.
# Once cryptography is bumped to the latest version, openssl1.1-compat should be removed and openssl1.1-compat-dev
# should be replaced by openssl-dev.
RUN apk add --no-cache bash openssh ca-certificates jq curl openssl openssl1.1-compat perl git zip \
&& apk add --no-cache --virtual .build-deps gcc make openssl1.1-compat-dev libffi-dev musl-dev linux-headers \
RUN apk add --no-cache bash openssh ca-certificates jq curl openssl perl git zip \
&& apk add --no-cache --virtual .build-deps gcc make openssl-dev libffi-dev musl-dev linux-headers \
Copy link
Contributor Author

@bebound bebound Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openssl-dev can also be removed. I guess this package is added as a dependency of cryptography https://cryptography.io/en/latest/installation/#building-cryptography-on-linux
I leave it here as I don't know if it is used by someone.

Copy link
Member

@jiasli jiasli Jan 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we keep openssl1.1-compat for now in case someone is using openssl1.1 command? But this is not very likely since openssl1.1-compat hasn't be introduced for a long time. I am not sure, though.

&& apk add --no-cache libintl icu-libs libc6-compat \
&& apk add --no-cache bash-completion \
&& update-ca-certificates
Expand Down