[Packaging] Remove openssl1.1-compat and use openssl-dev in docker image #25119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
added
the
Collaborator
|
Remove openssl1.1-compat |
bebound
commented
Jan 18, 2023
| RUN apk add --no-cache bash openssh ca-certificates jq curl openssl openssl1.1-compat perl git zip \ | ||
| && apk add --no-cache --virtual .build-deps gcc make openssl1.1-compat-dev libffi-dev musl-dev linux-headers \ | ||
| RUN apk add --no-cache bash openssh ca-certificates jq curl openssl perl git zip \ | ||
| && apk add --no-cache --virtual .build-deps gcc make openssl-dev libffi-dev musl-dev linux-headers \ |
Contributor
Author
There was a problem hiding this comment.
openssl-dev can also be removed. I guess this package is added as a dependency of cryptography https://cryptography.io/en/latest/installation/#building-cryptography-on-linux
I leave it here as I don't know if it is used by someone.
Member
There was a problem hiding this comment.
Perhaps we keep openssl1.1-compat for now in case someone is using openssl1.1 command? But this is not very likely since openssl1.1-compat hasn't be introduced for a long time. I am not sure, though.
bebound
changed the title
jiasli
approved these changes
Jan 18, 2023
jiasli
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert #24768, as #24793 is merged and cryptography and pyOpenSSL support openssl3.
Although
openssl1.1-compatis only available from 2.43.0, it's worth to mention this in changelog.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.